skb_migrate() / net/atm/ipcommon.c
Subsystems (2)
net/atm/ipcommon.c has a single function in it, skb_migrate which looks pretty generic and his this comment ontop of it:
*
* This function should live in skbuff.c or skbuff.h. *
So does this comment make sense, should it go into common code (and kill the major ugliness in net/atm/Makefile :))
Quoted 9 lines
net/atm/ipcommon.chas a single function in it,skb_migratewhich looks pretty generic and his this comment ontop of it:*
* This function should live inskbuff.corskbuff.h. *So does this comment make sense, should it go into common code (and kill the major ugliness in
net/atm/Makefile:))
i am fairly sure this function will go away in the future. its used to move an existing skb_queue to a new queue, so the queue can be 're-processed'. it seems to me that it might be easier to just find the current tail of the queue and process the queue to that point instead of copying to a new list. its on that list of things to do.
Quoted 6 lines · chas williams
i am fairly sure this function will go away in the future. its used to move an existing
skb_queueto a new queue, so the queue can be 're-processed'. it seems to me that it might be easier to just find the current tail of the queue and process the queue to that point instead of copying to a new list. its on that list of things to do.
Yes, my series of "backend" patches removes ipcommon.[ch] entirely. I'll try to send a rediff of them over the weekend if all the currently pending ATM patches land.
-Mitch