Skip to contentSkip to conversation

patch for 2.4.23pre6aa2 thinkpad compile errors

PATCH Anders Karlsson 1 participant 2 messages Oct 4, 2003 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

Hi,

When building the 2.4.23pre6aa2 kernel, there was some compile breaks in the new thinkpad support. All that was missing was an include line in some files, see attached patch.

Regards,

Signature · 5 lines
Anders Karlsson <[email protected]>
Trudheim Technology Ltd. - Linux System Administrator

PGP Usage Strongly Advised!!      My Key ID = 4B20601A
Fingerprint = 1B11 2F8C CBD6 7E53 E246  B23B 2D8C B0AA 4B20 601A
drivers/char/thinkpad/rtcmosram.c renamed from drivers/char/thinkpad/rtcmosram.c.orig +1 -0
@@ -30,6 +30,7 @@
 #include "thinkpad_driver.h"
 
 #include <linux/kernel.h>
+#include <linux/version.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
drivers/char/thinkpad/smapi_core.c renamed from drivers/char/thinkpad/smapi_core.c.orig +1 -0
@@ -30,6 +30,7 @@
 #include "thinkpad_driver.h"
 
 #include <linux/kernel.h>
+#include <linux/version.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/proc_fs.h>
drivers/char/thinkpad/superio.c renamed from drivers/char/thinkpad/superio.c.orig +1 -0
@@ -31,6 +31,7 @@
 #include "thinkpad_driver.h"
 
 #include <linux/kernel.h>
+#include <linux/version.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
drivers/char/thinkpad/thinkpad.c renamed from drivers/char/thinkpad/thinkpad.c.orig +1 -0
@@ -43,6 +43,7 @@
 #include <linux/module.h>
 #include <linux/kmod.h>
 #include <linux/kernel.h>
+#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/miscdevice.h>
 #include <linux/fs.h>
drivers/char/thinkpad/thinkpadpm.c renamed from drivers/char/thinkpad/thinkpadpm.c.orig +1 -0
@@ -31,6 +31,7 @@
 #include "thinkpad_driver.h"
 
 #include <linux/kernel.h>
+#include <linux/version.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/proc_fs.h>
#1 lore raw
Quoted 5 lines · Anders Karlsson

Hi,

When building the 2.4.23pre6aa2 kernel, there was some compile breaks in the new thinkpad support. All that was missing was an include line in some files, see attached patch.

Second comment to this, the thinkpad stuff can not be build into the kernel, even if the option to do so is there. It has to be built as modules. Perhaps a change to the *config stuff to reflect that is an idea? (I have no idea how to do that...)

Regards,

Signature · 2 lines
Anders Karlsson <[email protected]>
Trudheim Technology Limited