Skip to contentSkip to conversation

Mark aha152x as ISA and !64BIT driver

PATCH In review Andi Kleen 1 participant 2 messages Oct 7, 2003 SCSI

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 Mark aha152x as ISA and !64BIT driver

aha152x seems to be not 64bit safe and spews out warnings on x86-64. As I think it's a ISA only driver anyways I just marked it as ISA only and !64BIT for Alpha's sake.

drivers/scsi/Kconfig renamed from drivers/scsi/Kconfig-o +1 -1
diff -u linux-2.5-cleanup/drivers/scsi/Kconfig-o linux-2.5-cleanup/drivers/scsi/Kconfig
@@ -253,7 +253,7 @@
 
 config SCSI_AHA152X
 	tristate "Adaptec AHA152X/2825 support"
-	depends on ISA && SCSI
+	depends on ISA && SCSI && ISA && !64BIT
 	---help---
 	  This is a driver for the AHA-1510, AHA-1520, AHA-1522, and AHA-2825
 	  SCSI host adapters. It also works for the AVA-1505, but the IRQ etc.
author
#1 lore raw

Re: [PATCH] Mark aha152x as ISA and !64BIT driver II

Quoted 4 lines · Andi Kleen

aha152x seems to be not 64bit safe and spews out warnings on x86-64. As I think it's a ISA only driver anyways I just marked it as ISA only and !64BIT for Alpha's sake.

Matthew Wilcox pointed out that it was already marked ISA only. I actually ment to change another driver, but looking at the source of one it seems to be 64bit unclean too.

As there are 64bit architectures that have ISA slots (like old Alphas) I think this patch is still appropiate.

-Andi

drivers/scsi/Kconfig renamed from drivers/scsi/Kconfig-o +1 -1
diff -u linux-2.5-cleanup/drivers/scsi/Kconfig-o linux-2.5-cleanup/drivers/scsi/Kconfig
@@ -253,7 +253,7 @@
 
 config SCSI_AHA152X
 	tristate "Adaptec AHA152X/2825 support"
-	depends on ISA && SCSI
+	depends on ISA && SCSI && !64BIT
 	---help---
 	  This is a driver for the AHA-1510, AHA-1520, AHA-1522, and AHA-2825
 	  SCSI host adapters. It also works for the AVA-1505, but the IRQ etc.