failing unregister_ioctl32 is pretty fatal condition -- fix up message level

PATCH Pavel Machek 1 participant 1 message Oct 10, 2003

lore

Share & tools

lore

Pavel Machek

author

2003-10-10 10:04 UTC #0 lore raw

Hi!

AFAICS, kernel is likely to crash if someone does said ioctl after failed unregister. Please apply,
Pavel

drivers/ieee1394/video1394.c +1 -1

Index: linux/drivers/ieee1394/video1394.c
===================================================================
@@ -1424,7 +1424,7 @@
 	ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_TALK_WAIT_BUFFER);
 	ret |= unregister_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_POLL_BUFFER);
 	if (ret)
-		PRINT_G(KERN_INFO, "Error unregistering ioctl32 translations");
+		PRINT_G(KERN_CRIT, "Error unregistering ioctl32 translations");
 #endif
 
 	hpsb_unregister_protocol(&video1394_driver);

Signature · 2 lines

When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]