Skip to contentSkip to conversation

bug in ens1371/ens1370 joystick driver

DISCUSSION Juan Linietsky (by way of Juan Linietsky <[email protected]>) 2 participants 3 messages Oct 23, 2003 – Oct 24, 2003

lore
Share & tools
lore
#0 lore raw
Quoted 11 lines · you
Quoted 3 lines · Juan Linietsky

The ens1371 driver takes a joystick_port parameter with range 1..8 but that same parameter is them put into a switch to detect io port values like 0x200, 0x208, etc. so the joystick will never be detected.

ens1370.c says:
MODULE_PARM(joystick_port, "1-" __MODULE_STRING(SNDRV_CARDS) "i"); MODULE_PARM_DESC(joystick_port, "Joystick port address."); MODULE_PARM_SYNTAX(joystick_port, SNDRV_ENABLED

	",allows:{{0},{0x200},{0x208},{0x210},{0x218}},dialog:list");
Quoted 7 lines

The range 1..8 means that it's possible to specify a parameter value for each of the up to 8 cards (SNDRV_CARDS is defined as 8). The parameter itself takes the correct values.

Regards,
Clemens

this is still not very helpful, as modinfo -p only returns:

joystick_port int array (min = 1, max = 8), description "Joystick port address."

how are you supposed to know that you can only enter 0x200,0x208,etc? Specially when in the OSS driver you do:

modprobe es1371 joystick=1

and it works flawlessly

Regards

Juan Linietsky

-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/

#1 lore raw

At Thu, 23 Oct 2003 16:23:26 -0300,

Quoted 21 lines · Juan Linietsky
Quoted 11 lines · you
Quoted 3 lines · Juan Linietsky

The ens1371 driver takes a joystick_port parameter with range 1..8 but that same parameter is them put into a switch to detect io port values like 0x200, 0x208, etc. so the joystick will never be detected.

ens1370.c says:
MODULE_PARM(joystick_port, "1-" __MODULE_STRING(SNDRV_CARDS) "i"); MODULE_PARM_DESC(joystick_port, "Joystick port address."); MODULE_PARM_SYNTAX(joystick_port, SNDRV_ENABLED

	",allows:{{0},{0x200},{0x208},{0x210},{0x218}},dialog:list");
Quoted 7 lines

The range 1..8 means that it's possible to specify a parameter value for each of the up to 8 cards (SNDRV_CARDS is defined as 8). The parameter itself takes the correct values.

Regards,
Clemens

Quoted 6 lines

this is still not very helpful, as modinfo -p only returns:

joystick_port int array (min = 1, max = 8), description "Joystick port address."

how are you supposed to know that you can only enter 0x200,0x208,etc?

RTFM :)
alsa-kernel/Documentation/Joystick.txt.

Quoted 5 lines

Specially when in the OSS driver you do:

modprobe es1371 joystick=1

and it works flawlessly

ok, i'll add more code...

Takashi

-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/

#2 lore raw

At Fri, 24 Oct 2003 12:53:36 +0200,

Quoted 8 lines · I wrote:
Quoted 6 lines

Specially when in the OSS driver you do:

modprobe es1371 joystick=1

and it works flawlessly

ok, i'll add more code...

committed to cvs now.
the new version accepts like

modprobe snd-ens1371 joystick_port=1

for auto-detection of the joystick port.

Takashi

-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/