Skip to contentSkip to conversation

give SATA its' own menu

PATCH In review Adrian Bunk 4 participants 6 messages Oct 26, 2003 – Nov 12, 2003 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 give SATA its' own menu

Hi Jeff,

for an average user it's non-obvious to search for SATA support under SCSI. The patch below moves SATA suport out of SCSI and gives it an own menu below SCSI.

diffstat output:

 drivers/scsi/Kconfig |  110 ++++++++++++++++++++++---------------------
 1 files changed, 58 insertions(+), 52 deletions(-)

Please apply
Adrian

drivers/scsi/Kconfig renamed from drivers/scsi/Kconfig.old +58 -52
@@ -403,58 +403,6 @@
 	  To compile this driver as a module, choose M here: the
 	  module will be called megaraid.
 
-config SCSI_SATA
-	bool "Serial ATA (SATA) support"
-	depends on SCSI && EXPERIMENTAL
-	help
-	  This driver family supports Serial ATA host controllers
-	  and devices.
-
-	  If unsure, say N.
-
-config SCSI_SATA_SVW
-	tristate "ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)"
-	depends on SCSI_SATA && PCI && EXPERIMENTAL
-	help
-	  This option enables support for Broadcom/Serverworks/Apple K2
-	  SATA support.
-
-	  If unsure, say N.
-
-config SCSI_ATA_PIIX
-	tristate "Intel PIIX/ICH SATA support"
-	depends on SCSI_SATA && PCI
-	help
-	  This option enables support for ICH5 Serial ATA.
-	  If PATA support was enabled previously, this enables
-	  support for select Intel PIIX/ICH PATA host controllers.
-
-	  If unsure, say N.
-
-config SCSI_SATA_PROMISE
-	tristate "Promise SATA support"
-	depends on SCSI_SATA && PCI && EXPERIMENTAL
-	help
-	  This option enables support for Promise Serial ATA.
-
-	  If unsure, say N.
-
-config SCSI_SATA_SIL
-	tristate "Silicon Image SATA support"
-	depends on SCSI_SATA && PCI && BROKEN
-	help
-	  This option enables support for Silicon Image Serial ATA.
-
-	  If unsure, say N.
-
-config SCSI_SATA_VIA
-	tristate "VIA SATA support"
-	depends on SCSI_SATA && PCI && EXPERIMENTAL
-	help
-	  This option enables support for VIA Serial ATA.
-
-	  If unsure, say N.
-
 config SCSI_BUSLOGIC
 	tristate "BusLogic SCSI support"
 	depends on (PCI || ISA) && SCSI
@@ -1719,3 +1667,61 @@
 source "drivers/scsi/pcmcia/Kconfig"
 
 endmenu
+
+menu "Serial ATA (SATA) support"
+	depends on EXPERIMENTAL
+
+config SCSI_SATA
+	bool "Serial ATA (SATA) support"
+	depends on EXPERIMENTAL
+	select SCSI
+	help
+	  This driver family supports Serial ATA host controllers
+	  and devices.
+
+	  If unsure, say N.
+
+config SCSI_SATA_SVW
+	tristate "ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)"
+	depends on SCSI_SATA && PCI && EXPERIMENTAL
+	help
+	  This option enables support for Broadcom/Serverworks/Apple K2
+	  SATA support.
+
+	  If unsure, say N.
+
+config SCSI_ATA_PIIX
+	tristate "Intel PIIX/ICH SATA support"
+	depends on SCSI_SATA && PCI
+	help
+	  This option enables support for ICH5 Serial ATA.
+	  If PATA support was enabled previously, this enables
+	  support for select Intel PIIX/ICH PATA host controllers.
+
+	  If unsure, say N.
+
+config SCSI_SATA_PROMISE
+	tristate "Promise SATA support"
+	depends on SCSI_SATA && PCI && EXPERIMENTAL
+	help
+	  This option enables support for Promise Serial ATA.
+
+	  If unsure, say N.
+
+config SCSI_SATA_SIL
+	tristate "Silicon Image SATA support"
+	depends on SCSI_SATA && PCI && BROKEN
+	help
+	  This option enables support for Silicon Image Serial ATA.
+
+	  If unsure, say N.
+
+config SCSI_SATA_VIA
+	tristate "VIA SATA support"
+	depends on SCSI_SATA && PCI && EXPERIMENTAL
+	help
+	  This option enables support for VIA Serial ATA.
+
+	  If unsure, say N.
+
+endmenu
#1 lore raw
Quoted 5 lines · Adrian Bunk

Hi Jeff,

for an average user it's non-obvious to search for SATA support under SCSI. The patch below moves SATA suport out of SCSI and gives it an own menu below SCSI.

Will users know that they have to enable SCSI disk & cdrom support to get it really to work?
Petr

Quoted 9 lines
drivers/scsi/Kconfig renamed from drivers/scsi/Kconfig.old +9 -0
+config SCSI_SATA
+	bool "Serial ATA (SATA) support"
+	depends on EXPERIMENTAL
+	select SCSI
+	help
+	  This driver family supports Serial ATA host controllers
+	  and devices.
+
+	  If unsure, say N.
#2 lore raw
Quoted 3 lines

Will users know that they have to enable SCSI disk & cdrom support to get it really to work?
Petr

It will select SCSI automatically, see the "select SCSI" line.

Quoted 10 lines

drivers/scsi/Kconfig line 1682

Quoted 10 lines
drivers/scsi/Kconfig renamed from drivers/scsi/Kconfig.old +9 -0
+config SCSI_SATA
+    bool "Serial ATA (SATA) support"
+    depends on EXPERIMENTAL
+    select SCSI
+    help
+      This driver family supports Serial ATA host controllers
+      and devices.
+
+      If unsure, say N.

If you don't want to select something automatically, you could do it with a comment-to-the-user:

comment "Serial ATA needs SCSI support"
depends on !(SCSI && EXPERIMENTAL)
config SCSI_SATA
bool "Serial ATA (SATA) support"
depends on SCSI && EXPERIMENTAL

Signature · 2 lines
Try Linux 2.6 from BitKeeper for PXA2x0 CPUs at
http://www.mn-logistik.de/unsupported/linux-2.6/
#3 lore raw
In reply to Petr Vandrovec
Quoted 9 lines · Petr Vandrovec
Quoted 5 lines · Adrian Bunk

Hi Jeff,

for an average user it's non-obvious to search for SATA support under SCSI. The patch below moves SATA suport out of SCSI and gives it an own menu below SCSI.

Will users know that they have to enable SCSI disk & cdrom support to get it really to work?

I don't know the internals of the SATA driver, but this is unchanged from the current dependencies.

If this is required, I can send a patch that adds disk an cdrom options to SATA and select's the appropriate SCSI options.

Quoted 11 lines

Petr

drivers/scsi/Kconfig line 1682

Quoted 9 lines
drivers/scsi/Kconfig renamed from drivers/scsi/Kconfig.old +9 -0
+config SCSI_SATA
+	bool "Serial ATA (SATA) support"
+	depends on EXPERIMENTAL
+	select SCSI
+	help
+	  This driver family supports Serial ATA host controllers
+	  and devices.
+
+	  If unsure, say N.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
Quoted 3 lines · Adrian Bunk

I don't know the internals of the SATA driver, but this is unchanged from the current dependencies.

If this is required, I can send a patch that adds disk an cdrom options to SATA and select's the appropriate SCSI options.

If you didn't mind, such a patch would be nice...

Jeff

#5 lore raw
Quoted 9 lines · Jeff Garzik
Quoted 5 lines · Adrian Bunk

I don't know the internals of the SATA driver, but this is unchanged from the current dependencies.

If this is required, I can send a patch that adds disk an cdrom options to SATA and select's the appropriate SCSI options.

If you didn't mind, such a patch would be nice...

Below is a patch that gives SATA its' own menu, and additionally adds options that select SCSI disc or cdrom support if enabled.

Quoted 1 line

Jeff

cu
Adrian

drivers/scsi/Kconfig renamed from drivers/scsi/Kconfig.old +73 -52
@@ -1,3 +1,76 @@
+menu "Serial ATA (SATA) support"
+	depends on EXPERIMENTAL
+
+config SCSI_SATA
+	bool "Serial ATA (SATA) support"
+	depends on EXPERIMENTAL
+	select SCSI
+	help
+	  This driver family supports Serial ATA host controllers
+	  and devices.
+
+	  If unsure, say N.
+
+config SCSI_SATA_DISC
+	tristate "SATA disk support"
+	depends on SCSI_SATA
+	select BLK_DEV_SD
+	help
+	  This option enables support for SATA hard disks.
+
+config SCSI_SATA_CDROM
+	tristate "SATA CD-ROM support"
+	depends on SCSI_SATA
+	select BLK_DEV_SR
+	help
+	  This option enables support for SATA CD-ROMs.
+
+config SCSI_SATA_SVW
+	tristate "ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)"
+	depends on SCSI_SATA && PCI && EXPERIMENTAL
+	help
+	  This option enables support for Broadcom/Serverworks/Apple K2
+	  SATA support.
+
+	  If unsure, say N.
+
+config SCSI_ATA_PIIX
+	tristate "Intel PIIX/ICH SATA support"
+	depends on SCSI_SATA && PCI
+	help
+	  This option enables support for ICH5 Serial ATA.
+	  If PATA support was enabled previously, this enables
+	  support for select Intel PIIX/ICH PATA host controllers.
+
+	  If unsure, say N.
+
+config SCSI_SATA_PROMISE
+	tristate "Promise SATA support"
+	depends on SCSI_SATA && PCI && EXPERIMENTAL
+	help
+	  This option enables support for Promise Serial ATA.
+
+	  If unsure, say N.
+
+config SCSI_SATA_SIL
+	tristate "Silicon Image SATA support"
+	depends on SCSI_SATA && PCI && BROKEN
+	help
+	  This option enables support for Silicon Image Serial ATA.
+
+	  If unsure, say N.
+
+config SCSI_SATA_VIA
+	tristate "VIA SATA support"
+	depends on SCSI_SATA && PCI && EXPERIMENTAL
+	help
+	  This option enables support for VIA Serial ATA.
+
+	  If unsure, say N.
+
+endmenu
+
+
 menu "SCSI device support"
 
 config SCSI
@@ -403,58 +476,6 @@
 	  To compile this driver as a module, choose M here: the
 	  module will be called megaraid.
 
-config SCSI_SATA
-	bool "Serial ATA (SATA) support"
-	depends on SCSI && EXPERIMENTAL
-	help
-	  This driver family supports Serial ATA host controllers
-	  and devices.
-
-	  If unsure, say N.
-
-config SCSI_SATA_SVW
-	tristate "ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)"
-	depends on SCSI_SATA && PCI && EXPERIMENTAL
-	help
-	  This option enables support for Broadcom/Serverworks/Apple K2
-	  SATA support.
-
-	  If unsure, say N.
-
-config SCSI_ATA_PIIX
-	tristate "Intel PIIX/ICH SATA support"
-	depends on SCSI_SATA && PCI
-	help
-	  This option enables support for ICH5 Serial ATA.
-	  If PATA support was enabled previously, this enables
-	  support for select Intel PIIX/ICH PATA host controllers.
-
-	  If unsure, say N.
-
-config SCSI_SATA_PROMISE
-	tristate "Promise SATA support"
-	depends on SCSI_SATA && PCI && EXPERIMENTAL
-	help
-	  This option enables support for Promise Serial ATA.
-
-	  If unsure, say N.
-
-config SCSI_SATA_SIL
-	tristate "Silicon Image SATA support"
-	depends on SCSI_SATA && PCI && BROKEN
-	help
-	  This option enables support for Silicon Image Serial ATA.
-
-	  If unsure, say N.
-
-config SCSI_SATA_VIA
-	tristate "VIA SATA support"
-	depends on SCSI_SATA && PCI && EXPERIMENTAL
-	help
-	  This option enables support for VIA Serial ATA.
-
-	  If unsure, say N.
-
 config SCSI_BUSLOGIC
 	tristate "BusLogic SCSI support"
 	depends on (PCI || ISA) && SCSI