Skip to contentSkip to conversation

BUGFIX for powernow-k8

PATCH New Dominik Brodowski 1 participant 1 message Nov 4, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 BUGFIX for powernow-k8

Hi Dave, Paul,

Here is an important bugfix for powernow-k8.c in its current form (2.6.0-test9).

Problem description:
As the powernow-k8 driver uses the ->target and not the ->setpolicy callback, cpufreq_policy->policy is always zero. Checking for it in the powernow-k8 driver always returned "false". So we can easily remove this invalid check (and the #warning added to denote this).

arch/i386/kernel/cpu/cpufreq/powernow-k8.c +1 -3
diff -ruN linux-original/arch/i386/kernel/cpu/cpufreq/powernow-k8.c linux/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
@@ -935,10 +935,8 @@
 		return -ENODEV;
 	}
 
-#warning pol->policy is in undefined state here
 	res = find_match(&targ, &min, &max,
-			 pol->policy == CPUFREQ_POLICY_POWERSAVE ?
-			 SEARCH_DOWN : SEARCH_UP, 0, 0);
+			 SEARCH_DOWN, 0, 0);
 	if (!res) {
 		pol->min = min * 1000;
 		pol->max = max * 1000;

_______________________________________________
Cpufreq mailing list
[email protected]
http://www.linux.org.uk/mailman/listinfo/cpufreq