Skip to contentSkip to conversation

alsa-lib: Error code 1 from snd_mixer_selem_set_capture_switch_all()

DISCUSSION Christian Esken 2 participants 3 messages Nov 12, 2003 – Nov 19, 2003

lore
Share & tools
lore
#0 lore raw

Hello,

I have a problem with snd_mixer_selem_set_capture_switch_all() from alsa-lib. The documentation states:

/**
* \brief Set value of capture switch control for all channels of a mixer
simple element
* \param elem Mixer simple element handle
* \param value control value
* \return 0 on success otherwise a negative error code
*/
int snd_mixer_selem_set_capture_switch_all(snd_mixer_elem_t *elem, int value)

So I should receive either 0 or a negative value. But I receive a return value of 1. Does anybody know what this means?!? Any help is appreciated greatly.

Greetings,
Chris

-------------------------------------------------------
This SF.Net email sponsored by: ApacheCon 2003, 16-19 November in Las Vegas. Learn firsthand the latest developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV, and more! http://www.apachecon.com/

#1 lore raw

Bug in alsa-lib (Was: alsa-lib: Error code 1 from snd_mixer_selem_set_capture_switch_all() )

Quoted 15 lines · Christian Esken

Hello,

I have a problem with snd_mixer_selem_set_capture_switch_all() from alsa-lib. The documentation states:

/**
* \brief Set value of capture switch control for all channels of a mixer
simple element
* \param elem Mixer simple element handle
* \param value control value
* \return 0 on success otherwise a negative error code
*/
int snd_mixer_selem_set_capture_switch_all(snd_mixer_elem_t *elem, int value)

Quoted 3 lines

So I should receive either 0 or a negative value. But I receive a return value of 1. Does anybody know what this means?!? Any help is appreciated greatly.

I have investigated and found a possible bug in alsa-lib.
The documentation of snd_mixer_selem_set_capture_switch_all() only mentions return codes 0 and <0. As I said 1 is returned in my case - I now found a place where this could happen in the alsa-lib source code. The code is from src/mixer/simple.c , revision .59.

snd_mixer_selem_set_capture_switch_all() calls selem_write, which calls selem_read(). At the end of selem_read(), you find the following code snippet:

        if (memcmp(pvol, s->str[PLAY].vol, sizeof(pvol)) ||
            psw != s->str[PLAY].sw ||
            memcmp(cvol, s->str[CAPT].vol, sizeof(cvol)) ||
            csw != s->str[CAPT].sw)
                return 1;

This is where 1 is returned. But I do not understand the code. Can anybody explain to me. It looks a bit like I am passing "bad" parameters, but then I would expect to be returned an error code like EINVAL.

Greetings,
Chris

-------------------------------------------------------
This SF. Net email is sponsored by: GoToMyPC
GoToMyPC is the fast, easy and secure way to access your computer from any Web browser or wireless device. Click here to Try it Free!
https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl

#2 lore raw

Re: Bug in alsa-lib (Was: alsa-lib: Error code 1 from snd_mixer_selem_set_capture_switch_all() )

At Sat, 15 Nov 2003 11:24:10 +0100,

Quoted 21 lines · Christian Esken
Quoted 15 lines · Christian Esken

Hello,

I have a problem with snd_mixer_selem_set_capture_switch_all() from alsa-lib. The documentation states:

/**
* \brief Set value of capture switch control for all channels of a mixer
simple element
* \param elem Mixer simple element handle
* \param value control value
* \return 0 on success otherwise a negative error code
*/
int snd_mixer_selem_set_capture_switch_all(snd_mixer_elem_t *elem, int value)

Quoted 3 lines

So I should receive either 0 or a negative value. But I receive a return value of 1. Does anybody know what this means?!? Any help is appreciated greatly.

Quoted 5 lines

I have investigated and found a possible bug in alsa-lib.
The documentation of snd_mixer_selem_set_capture_switch_all() only mentions return codes 0 and <0. As I said 1 is returned in my case - I now found a place where this could happen in the alsa-lib source code. The code is from src/mixer/simple.c , revision .59.

yes, you're right. it's a bug.

Quoted 12 lines

snd_mixer_selem_set_capture_switch_all() calls selem_write, which calls selem_read(). At the end of selem_read(), you find the following code snippet:

        if (memcmp(pvol, s->str[PLAY].vol, sizeof(pvol)) ||
            psw != s->str[PLAY].sw ||
            memcmp(cvol, s->str[CAPT].vol, sizeof(cvol)) ||
            csw != s->str[CAPT].sw)
                return 1;
Quoted 3 lines

This is where 1 is returned. But I do not understand the code. Can anybody explain to me. It looks a bit like I am passing "bad" parameters, but then I would expect to be returned an error code like EINVAL.

the return value of selem_read() is evaluated to throw the event after read internally (i.e. if positive value is returned).

the attached patch should fix the positive return-value problem. i change this on cvs.

thanks,

Takashi