Skip to contentSkip to conversation

sis comparison / assignment operator fix

PATCH New Geoffrey Lee 1 participant 1 message Nov 24, 2003 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sis comparison / assignment operator fix

Hi,

This fixes what seems to be an obvious = vs == bug in the init301.c sis file.

It has

if (temp = 0xffff) return;

which should always be true, so it always returns.

- g.

Signature · 1 line
geoff.
drivers/video/sis/init301.c renamed from drivers/video/sis/init301.c.orig +1 -1
@@ -11712,7 +11712,7 @@ SetOEMLCDData(SiS_Private *SiS_Pr, PSIS_
   }
 
   temp = GetOEMLCDPtr(SiS_Pr,HwDeviceExtension, ROMAddr, 1);
-  if(temp = 0xFFFF) return;
+  if(temp == 0xFFFF) return;
 
   index = SiS_Pr->SiS_VBModeIDTable[ModeIdIndex]._VB_LCDHIndex;
   for(i=0x14, j=0; i<=0x17; i++, j++) {