Skip to contentSkip to conversation

Oops with tmpfs on both 2.4.22 & 2.6.0-test11

DISCUSSION James W McMechan 2 participants 2 messages Dec 3, 2003

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines

Hi,

I hope nobody minds me jumping in this thread. I have been looking at this code for some time and hope I have got the facts correct.

Thank you, so far it is no longer crashing :)

Quoted 5 lines

The two list_xxx macros as mentioned (fs/libfs.c:line 137) adjusts the cursor dentry to the beginning of the d_subdirs list needed for (file->f_pos == 2) as there can be additions in the d_subdirs list after the open call and before ->lseek or ->readdir call.

Quoted 9 lines

The cursor adjustment in dcache_dir_lseek() (fs/libfs.c: line 90) always puts the cursor just before the last looked dentry in the while loop.

But it is problematic when we have an empty directory and (file->f_pos == 2)
In this case we have the loop counter p pointing to the cursor and doing list_del and list_add_tail of the same list node results in oops.

This is where I get mildly lost, from what you are saying here I would have expected a test on list_empty rather than on fpos==2 also this occurs in every file, will starting in a different pos in the list cause problems?

With further testing it also Oops even when the dir is not empty I did a "touch /dev/shm/1 /dev/shm/2 /dev/shm/3" to put some entries in the dir first and the original still oops at offset 2

I should do more testing, to see if I can find out what happens on non empty dirs, because I was thinking it was due to the dir being empty, which now appears not to be true.

Quoted 4 lines

The following patch takes (file->f_post == 2) as a special case and adjusts the cursor dentry by putting it right at the beginning of the d_subdirs list.

Also is the new variable dentry needed or just a optimization? It looks functionally equivalent, but perhaps it is needed for something I am not seeing at the moment.

Quoted 3 lines

Thanks
Maneesh

________________________________________________________________
The best thing to hit the internet in years - Juno SpeedBand! Surf the web up to FIVE TIMES FASTER!
Only $14.95/ month - visit www.juno.com to sign up today!

#1 lore raw

On Wed, Dec 03, 2003 at 03:06:14AM -0800, James W McMechan wrote:
[..]

Quoted 10 lines
Quoted 10 lines

The cursor adjustment in dcache_dir_lseek() (fs/libfs.c: line 90) always puts the cursor just before the last looked dentry in the while loop.

But it is problematic when we have an empty directory and (file->f_pos == 2)
In this case we have the loop counter p pointing to the cursor and doing list_del and list_add_tail of the same list node results in oops.

Quoted 4 lines

This is where I get mildly lost, from what you are saying here I would have expected a test on list_empty rather than on fpos==2 also this occurs in every file, will starting in a different pos in the list cause problems?

The cursor dentry is added in d_subdirs list in the ->open call for the directory. So even if directory is empty from a user point of view, the d_subdirs list will ateast have the cursor dentry. In other words when we come to ->lseek or ->readdir call, we will not have empty d_subdirs list.

Quoted 8 lines

With further testing it also Oops even when the dir is not empty I did a "touch /dev/shm/1 /dev/shm/2 /dev/shm/3" to put some entries in the dir first and the original still oops at offset 2

I should do more testing, to see if I can find out what happens on non empty dirs, because I was thinking it was due to the dir being empty, which now appears not to be true.

humm.. yeah.. the original case will always oops for offset 2 irrespective of whether directory is empty or not. Because in case of non-empty dir also we will have p pointing to cursor dentry for offset 2. Thanks for letting me know one more fact.

Quoted 8 lines
Quoted 5 lines

The following patch takes (file->f_post == 2) as a special case and adjusts the cursor dentry by putting it right at the beginning of the d_subdirs list.

Also is the new variable dentry needed or just a optimization? It looks functionally equivalent, but perhaps it is needed for something I am not seeing at the moment.

That's just to make code readable, without this it will have line beyond 80 columns and also it has to de-reference multiple levels of pointers.

Thanks
Maneesh

Signature · 6 lines
Maneesh Soni
Linux Technology Center, 
IBM Software Lab, Bangalore, India
email: [email protected]
Phone: 91-80-5044999 Fax: 91-80-5268553
T/L : 9243696