Skip to contentSkip to conversation

more i2c bus drivers (1/2)

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 more i2c bus drivers (1/2)

This patch fixes i2c_smbus_write_byte() being broken for i2c-amd8111. This causes trouble when that module is used together with eeprom (which is also in 2.6). We have had no report so far, but the problem is similar to the one addressed by a recent patch to i2c-nforce2.

Credits go to Hans-Frieder Vogt for finding and fixing the problem. Mark D. Studebaker found and fixed the original problem in i2c-nforce2.

This is a serious bug fix, and I believe you shouldn't wait too long before applying it.

drivers/i2c/busses/i2c-amd8111.c renamed from drivers/i2c/busses/i2c-amd8111.c.orig +1 -1
@@ -192,7 +192,7 @@
 
 		case I2C_SMBUS_BYTE:
 			if (read_write = I2C_SMBUS_WRITE)
-				amd_ec_write(smbus, AMD_SMB_DATA, data->byte);
+				amd_ec_write(smbus, AMD_SMB_CMD, command);
 			protocol |= AMD_SMB_PRTCL_BYTE;
 			break;
 
Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
Applied
#1 lore raw

PATCH 1/1 more i2c bus drivers (1/2)

Quoted 10 lines · Jean Delvare

This patch fixes i2c_smbus_write_byte() being broken for i2c-amd8111. This causes trouble when that module is used together with eeprom (which is also in 2.6). We have had no report so far, but the problem is similar to the one addressed by a recent patch to i2c-nforce2.

Credits go to Hans-Frieder Vogt for finding and fixing the problem. Mark D. Studebaker found and fixed the original problem in i2c-nforce2.

This is a serious bug fix, and I believe you shouldn't wait too long before applying it.

Applied, thanks.

greg k-h