Skip to contentSkip to conversation

commonspartan

PATCH New Robert Schwebel 2 participants 2 messages Dec 15, 2003 – Jan 3, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 5/6 commonspartan

-------------- next part --------------

#
# Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
#

common/spartan2.c renamed from common/spartan2.c~commonspartan +1 -1
@@ -516,7 +516,7 @@
 				(*fn->clk) (FALSE, TRUE, cookie);
 				CONFIG_FPGA_DELAY ();
 				/* Write data */
-				(*fn->wr) ((val < 0), TRUE, cookie);
+				(*fn->wr) ((val & 0x80), TRUE, cookie);
 				CONFIG_FPGA_DELAY ();
 				/* Assert the clock */
 				(*fn->clk) (TRUE, TRUE, cookie);
#1 lore raw

PATCH 5/6 commonspartan

common/spartan2.c line 522

Quoted 13 lines · In message <[email protected]> you wrote:
common/spartan2.c renamed from common/spartan2.c~commonspartan +1 -1
@@ -516,7 +516,7 @@
 				(*fn->clk) (FALSE, TRUE, cookie);
 				CONFIG_FPGA_DELAY ();
 				/* Write data */
-				(*fn->wr) ((val < 0), TRUE, cookie);
+				(*fn->wr) ((val & 0x80), TRUE, cookie);
 				CONFIG_FPGA_DELAY ();
 				/* Assert the clock */
 				(*fn->clk) (TRUE, TRUE, cookie);

Please explain why you think this patch is needed, i. e. which problem it fixes. At least provide a CHANGELOG entry.

Rejected.

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
"The two most common things in the universe are hydrogen  and  stupi-
dity."