Skip to contentSkip to conversation

clean up fs/devfs/base.c

PATCH Ian Kent 3 participants 7 messages Dec 24, 2003 – Dec 27, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ian Kent

author
#1 lore raw
Quoted 8 lines · Greg KH
Quoted 3 lines · Andrew Morton

Now would be a good time for someone to feed the whole thing through indent though.

As much as I enjoy using the devfs code as my "bad coding style" example, here's a patch against 2.6.0 that cleans up the devfs code to follow the proper kernel coding style.

I think it needs a little bit more than that Greg.

I would like to (will) spend some time on it over the next couple of days.

Ian

#2 lore raw
Quoted 4 lines · Ian Kent
Quoted 2 lines · Greg KH
Quoted 1 line · Andrew Morton
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Now would be a good time for someone to feed the whole thing through indent though.

As much as I enjoy using the devfs code as my "bad coding style" example, here's a patch against 2.6.0 that cleans up the devfs code to follow the proper kernel coding style.

I think it needs a little bit more than that Greg.

Oh, I know it does. That was just a "convert to proper coding format in 15 minutes" patch. You should start with that and work from there. But, if you are going to do this, remember to submit in incremental changes. I suggest this patch go in, as it is just a reformatting, nothing else. Then you can work from there, changing the actual logic of the code.

thanks,

greg k-h

#3 lore raw
Quoted 13 lines · Greg KH
Quoted 11 lines · Ian Kent
Quoted 8 lines · Greg KH
Quoted 3 lines · Andrew Morton

Now would be a good time for someone to feed the whole thing through indent though.

As much as I enjoy using the devfs code as my "bad coding style" example, here's a patch against 2.6.0 that cleans up the devfs code to follow the proper kernel coding style.

Quoted 8 lines
Quoted 1 line

I think it needs a little bit more than that Greg.

Oh, I know it does. That was just a "convert to proper coding format in 15 minutes" patch. You should start with that and work from there. But, if you are going to do this, remember to submit in incremental changes. I suggest this patch go in, as it is just a reformatting, nothing else. Then you can work from there, changing the actual logic of the code.

Yup, just whitespace fixes please. I don't think I have the energy for a big cleanup exercise right now, and it's not really appropriate.

author
#4 lore raw
Quoted 11 lines · Andrew Morton
Quoted 7 lines

Oh, I know it does. That was just a "convert to proper coding format in 15 minutes" patch. You should start with that and work from there. But, if you are going to do this, remember to submit in incremental changes. I suggest this patch go in, as it is just a reformatting, nothing else. Then you can work from there, changing the actual logic of the code.

Yup, just whitespace fixes please. I don't think I have the energy for a big cleanup exercise right now, and it's not really appropriate.

OK. Didn't see this yet.

I'll test what I have and get an initial patch to you.

Ian

author
#5 lore raw
In reply to Andrew Morton
Quoted 4 lines · Andrew Morton

Yup, just whitespace fixes please. I don't think I have the energy for a big cleanup exercise right now, and it's not really appropriate.

OK. Got side tracked for a while.

White space only (just about) patch is on kernel.org at:

/pub/linux/kernel/perope/raven/devfs/linux-2.6.0-devfs-1.patch

It compiles, links and basic functionality tested OK with devfsd 1.3.25, against 2.6.0.

Ian

author
#6 lore raw
Quoted 7 lines · Ian Kent
Quoted 4 lines · Andrew Morton

Yup, just whitespace fixes please. I don't think I have the energy for a big cleanup exercise right now, and it's not really appropriate.

Quoted 9 lines

OK. Got side tracked for a while.

White space only (just about) patch is on kernel.org at:

/pub/linux/kernel/perope/raven/devfs/linux-2.6.0-devfs-1.patch

It compiles, links and basic functionality tested OK with devfsd 1.3.25, against 2.6.0.

Have done a 2nd pass of devfs for 'almost white space only' changes. It is in linux-2.6.0-devfs-2.patch. I have tested it as I did the first. It should be applied over the first.

Have run out of time now so that will have to be it for now.

Ian

author
#7 lore raw
In reply to Greg KH
Quoted 8 lines · Greg KH
Quoted 1 line

I think it needs a little bit more than that Greg.

Oh, I know it does. That was just a "convert to proper coding format in 15 minutes" patch. You should start with that and work from there. But, if you are going to do this, remember to submit in incremental changes. I suggest this patch go in, as it is just a reformatting, nothing else. Then you can work from there, changing the actual logic of the code.

Yep. I have started with the patch you provided. Thanks.

I'm a bit of a white space obsessive compulsive type so I have made a fair few more changes. I tried hard to resist changing the code but some of those long lines just had to go.

I'm having difficulty resisting breaking up base.c. I just can't bare 3000+ lines in one source file.

I'm thinking I should just go ahead, do a limited test and then get a couple of people that use devfs to test it before submitting it.

Mind, I'm not changing the logic, just the layout and structure.

You don't agree I think.

I'm making patches as I go so I can do the incremental thing without being held up. I have the time to do this now, over the Xmas break, so I'll go ahead and return to fix things if I need to.

Lets not loose sight of the reason I volunteered to provide maintenance only, best effort only fixes during the deprecation process. That is, as you know, to quell the unrest on the list regarding devfs, so that people like yourself can get on with udev.

Simple things like replacing OBSOLETE with DEPRECATED in fs/Kconfig and rewording last paragraph to better reflect Andrews actual intent would help a lot.

So it's Xmas day and I shouldn't be so serious. Hope everyone has a great day.
Indeed, some of us won't get to it till tomorrow, fantastic.

Ian