Skip to contentSkip to conversation

Add support for checking before-the-fact whether an IRQ is

DISCUSSION Arjan van de Ven 3 participants 3 messages Dec 29, 2003 – Dec 30, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 9 lines · Linux Kernel Mailing List

ChangeSet 1.1552, 2003/12/29 10:18:11-08:00, [email protected]

Add support for checking before-the-fact whether an IRQ is already registered or not. The x86 PCI layer wants this for its availability testing.

Doing a request_irq()/free_irq() pair to check this condition like we used to do can lock the machine if the irq happens to be screaming.

question; which lock prevents someone else claiming the irq and making it unsharable/unclaimable between can_request_irq() and the eventual request_irq() ????

#2 lore raw
Quoted 7 lines · Arjan van de Ven
Quoted 6 lines · Linux Kernel Mailing List

ChangeSet 1.1552, 2003/12/29 10:18:11-08:00, [email protected]

Add support for checking before-the-fact whether an IRQ is already registered or not. The x86 PCI layer wants this for its availability testing.

Quoted 8 lines
Quoted 3 lines

Doing a request_irq()/free_irq() pair to check this condition like we used to do can lock the machine if the irq happens to be screaming.

question; which lock prevents someone else claiming the irq and making it unsharable/unclaimable between can_request_irq() and the eventual request_irq() ????

Nothing. It never did. This is basically a heuristic: "find the irq that looks the least used".

I just fixed the heuristic so that it shouldn't cause problems if the system comes up with the BIOS having done something silly like leaving an irq pending..

Linus

#3 lore raw
Quoted 6 lines · On Mon, 29 Dec 2003 11:43:29 -0800 (PST) Linus Torvalds <[email protected]>…
Quoted 3 lines

question; which lock prevents someone else claiming the irq and making it unsharable/unclaimable between can_request_irq() and the eventual request_irq() ????

Nothing. It never did. This is basically a heuristic: "find the irq that looks the least used".

I just worry about other people using it. I'd prefer "irq_looks_free()", but since it's x86-specific it's not a big issue.

Rusty.

Signature · 2 lines
   there are those who do and those who hang on and you don't see too
   many doers quoting their contemporaries.  -- Larry McVoy