Skip to contentSkip to conversation

Updating our sn code in 2.6] - Patch 028

PATCH Andrew Morton 3 participants 4 messages Jan 10, 2004 – Jan 12, 2004 Bitmap API

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines · Paul Jackson

Rusty, responding to Andrew, on a cpumask failure seen by Jesse:

Quoted 1 line

Probably. Paul Jackson acked them though, so I'm a little surprised.

Quoted 9 lines

Jesse or Rusty - could you send me the earlier parts of this email thread? I don't see it on lkml or ia64 email list.

I'd like to see what I missed in Rusty's patch.

Though I am less surprised than Rusty that I missed something; I was in an easy going frame of mind when I read it. I do tougher reviews when I am more irritated and untrusting.

Is OK, looks like Rusty was missing a couple of mk_cpumask_const() invokations in a -mm patch. I'm currently testing this:

include/linux/cpumask.h renamed from include/linux/cpumask.h~make-for_each_cpu-iterator-more-friendly-fix-fix +4 -4
@@ -14,10 +14,10 @@ extern cpumask_t cpu_possible_map;
 #define cpu_online(cpu)			cpu_isset(cpu, cpu_online_map)
 #define cpu_possible(cpu)		cpu_isset(cpu, cpu_possible_map)
 
-#define for_each_cpu_mask(cpu, mask)			\
-	for (cpu = first_cpu_const(mask);		\
-		cpu < NR_CPUS;				\
-		cpu = next_cpu_const(cpu, mask))
+#define for_each_cpu_mask(cpu, mask)					\
+	for (cpu = first_cpu_const(mk_cpumask_const(mask));		\
+		cpu < NR_CPUS;						\
+		cpu = next_cpu_const(cpu, mk_cpumask_const(mask)))
 
 #define for_each_cpu(cpu) for_each_cpu_mask(cpu, cpu_possible_map)
 #define for_each_online_cpu(cpu) for_each_cpu_mask(cpu, cpu_online_map)

_

#1 lore raw
Quoted 1 line

Is OK, looks like Rusty was missing a couple of mk_cpumask_const()

Thank-you, Andrew.

Signature · 3 lines
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <[email protected]> 1.650.933.1373
#2 lore raw
In reply to Andrew Morton

2.6.1-mm2 compiles with NR_CPUSQ2 (and for sn2 btw, thanks), but I haven't actually booted it on a >256p machine since they're still somewhat rare :). Do you think you'll do an official 2.6.2 release before Linus gets back with this stuff in it?

Thanks,
Jesse

Quoted 42 lines · Andrew Morton
Quoted 4 lines · Paul Jackson

Rusty, responding to Andrew, on a cpumask failure seen by Jesse:

Quoted 1 line

Probably. Paul Jackson acked them though, so I'm a little surprised.

Quoted 9 lines

Jesse or Rusty - could you send me the earlier parts of this email thread? I don't see it on lkml or ia64 email list.

I'd like to see what I missed in Rusty's patch.

Though I am less surprised than Rusty that I missed something; I was in an easy going frame of mind when I read it. I do tougher reviews when I am more irritated and untrusting.

Is OK, looks like Rusty was missing a couple of mk_cpumask_const() invokations in a -mm patch. I'm currently testing this:

include/linux/cpumask.h renamed from include/linux/cpumask.h~make-for_each_cpu-iterator-more-friendly-fix-fix +4 -4
@@ -14,10 +14,10 @@ extern cpumask_t cpu_possible_map;
 #define cpu_online(cpu)			cpu_isset(cpu, cpu_online_map)
 #define cpu_possible(cpu)		cpu_isset(cpu, cpu_possible_map)
 
-#define for_each_cpu_mask(cpu, mask)			\
-	for (cpu = first_cpu_const(mask);		\
-		cpu < NR_CPUS;				\
-		cpu = next_cpu_const(cpu, mask))
+#define for_each_cpu_mask(cpu, mask)					\
+	for (cpu = first_cpu_const(mk_cpumask_const(mask));		\
+		cpu < NR_CPUS;						\
+		cpu = next_cpu_const(cpu, mk_cpumask_const(mask)))
 
 #define for_each_cpu(cpu) for_each_cpu_mask(cpu, cpu_possible_map)
 #define for_each_online_cpu(cpu) for_each_cpu_mask(cpu, cpu_online_map)

_

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to Andrew Morton
Quoted 4 lines · [email protected] (Jesse Barnes) wrote:

2.6.1-mm2 compiles with NR_CPUSQ2 (and for sn2 btw, thanks), but I haven't actually booted it on a >256p machine since they're still somewhat rare :).

Yup.

Quoted 2 lines

Do you think you'll do an official 2.6.2 release
before Linus gets back with this stuff in it?

No, 2.6.2 will be at least a couple of weeks away I expect.