fix a drivers/char/isicom.c compile warning

I got the following compile warning in 2.6.1-mm2 (but it doesn't seem to be specific to -mm):

<-- snip -->

...
CC [M] drivers/char/isicom.o
...
drivers/char/isicom.c: In function `unregister_drivers':
drivers/char/isicom.c:1677: warning: `error' might be used uninitialized in this function
...

<-- snip -->

The following patch fixes this issue:

Em Tue, Jan 13, 2004 at 01:00:56AM +0100, Adrian Bunk escreveu:
...

drivers/char/isicom.c line 1679

Quoted 12 lines

The following patch fixes this issue:

drivers/char/isicom.c renamed from drivers/char/isicom.c.old +1 -1

@@ -1675,7 +1675,7 @@
 static void unregister_drivers(void)
 {
 	int error;
-	if (tty_unregister_driver(isicom_normal))
+	if ((error=tty_unregister_driver(isicom_normal)))
 		printk(KERN_DEBUG "ISICOM: couldn't unregister normal driver error=%d.\n",error);

OK, the patch is right, but couldn't we take the opportunity to make this more readable while at it? Ssomething like:

static void unregister_drivers(void)

{
        int error = tty_unregister_driver(isicom_normal);

        if (error)
		printk(KERN_DEBUG "ISICOM: couldn't unregister normal "
				  "driver error=%d.\n", error);

? :-)

- Arnaldo

Quoted 26 lines

Em Tue, Jan 13, 2004 at 01:00:56AM +0100, Adrian Bunk escreveu:
...

drivers/char/isicom.c line 1679

Quoted 12 lines

The following patch fixes this issue:

drivers/char/isicom.c renamed from drivers/char/isicom.c.old +1 -1

@@ -1675,7 +1675,7 @@
 static void unregister_drivers(void)
 {
 	int error;
-	if (tty_unregister_driver(isicom_normal))
+	if ((error=tty_unregister_driver(isicom_normal)))
 		printk(KERN_DEBUG "ISICOM: couldn't unregister normal driver error=%d.\n",error);

OK, the patch is right, but couldn't we take the opportunity to make this more readable while at it? Ssomething like:

static void unregister_drivers(void)

{
        int error = tty_unregister_driver(isicom_normal);

        if (error)
		printk(KERN_DEBUG "ISICOM: couldn't unregister normal "
				  "driver error=%d.\n", error);

Quoted 1 line

? :-)

I thought about it, but I wasn't sure whether changing a driver to be more readable in _one_ place and making the code there different from the coding style used in the rest of the driver is really an improvement (and no, I don't want to clean the whole driver...)?

Quoted 4 lines

I thought about it, but I wasn't sure whether changing a driver to be more readable in _one_ place and making the code there different from the coding style used in the rest of the driver is really an improvement (and no, I don't want to clean the whole driver...)?

Humm, IMHO it is better to get it with mixed style as long as the changes that "break" the style are for the correct style, but this, of course, for purely unmaintained stuff, like... isicom.c :-) For maintained stuff it becomes a pain in the ass for the maintainer, that should try to follow CodingStyle, but as we know, not always do.