A little ctc cleanup

PATCH Pete Zaitcev 1 participant 1 message Jan 16, 2004

Subsystems (3)

Network drivers s390 s390 network drivers

lore

Share & tools

lore

Pete Zaitcev

author

2004-01-16 20:23 UTC #0 lore raw

Hi, Martin:

With the current state machine, doing fsm_event(DEV_EVENT_STOP) is an exact equivalent of dev_action_stop, only it adds a (superfluous) debugging tracepoint, which is useless anyway, because dev_action_restart is an action, so its caller does the same.

My compliments to Fritz and please ask him to accept this.

-- Pete

drivers/s390/net/ctcmain.c +1 -2

@@ -2075,10 +2075,9 @@
 {
 	struct net_device *dev = (struct net_device *)arg;
 	struct ctc_priv *privptr = dev->priv;
-	
+
 	printk(KERN_DEBUG "%s: Restarting\n", dev->name);
 	dev_action_stop(fi, event, arg);
-	fsm_event(privptr->fsm, DEV_EVENT_STOP, dev);
 	fsm_addtimer(&privptr->restart_timer, CTC_TIMEOUT_5SEC,
 		     DEV_EVENT_START, dev);
 }