Skip to contentSkip to conversation

sched-idle and disk-priorities for 2.6.X

DISCUSSION Pavel Machek 5 participants 19 messages Jan 16, 2004 – Feb 3, 2004

lore
Share & tools
lore
#0 lore raw

Hi!

I have some lingvistics application here that is pretty demanding... it eats a lot of memory, overloads disk, and basically makes system unusable for even as simple tasks as reading maillists.

I basically don't care about performance of that job, as long as it does progress at least when I'm not in front of the computer. But I'd like to have my machine usable...

Any ideas?

Where are lastest versions of disk-prio and sched-idle patches?

Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#1 lore raw
Quoted 5 lines · Pavel Machek

I have some lingvistics application here that is pretty demanding... it eats a lot of memory, overloads disk, and basically makes system unusable for even as simple tasks as reading maillists.

Where are lastest versions of disk-prio and sched-idle patches?

The most likely culprit here is "eats memory". What's almost certainly happening is that your application is using a lot of pages, and leaving the system in thrashing mode. Quite likely, "sched-idle" won't do what you want, as all that will happen is that the application will dirty pages while the CPU is otherwise idle (and cause the same problem you're seeing already). Similarly, disk-prio doesn't do you any good, because it isn't the I/O of the huge application that's the problem, it's the I/O for the processes that are thrashing.

A better bet would be a patch that allowed you to set the maximum RSS size for the process so it can basically thrash itself while leaving enough memory for everybody else (and yes, I *know* how this can be self-defeating if the thrashing app then increases the total I/O consumed to be higher than the I/O bandwidth available - the point is that it's probably the high RSS value for his application causing OTHER things to thrash that's the root cause of his performance problem).

#2 lore raw
Quoted 7 lines · [email protected] wrote:

A better bet would be a patch that allowed you to set the maximum RSS size for the process so it can basically thrash itself while leaving enough memory for everybody else (and yes, I *know* how this can be self-defeating if the thrashing app then increases the total I/O consumed to be higher than the I/O bandwidth available - the point is that it's probably the high RSS value for his application causing OTHER things to thrash that's the root cause of his performance problem).

Or you could use "ulimit -m" to set the RSS, of course.

Signature · 3 lines
bill davidsen <[email protected]>
  CTO TMR Associates, Inc
  Doing interesting things with small computers since 1979
#3 lore raw
Quoted 11 lines · Bill Davidsen
Quoted 7 lines · [email protected] wrote:

A better bet would be a patch that allowed you to set the maximum RSS size for the process so it can basically thrash itself while leaving enough memory for everybody else (and yes, I *know* how this can be self-defeating if the thrashing app then increases the total I/O consumed to be higher than the I/O bandwidth available - the point is that it's probably the high RSS value for his application causing OTHER things to thrash that's the root cause of his performance problem).

Quoted 1 line

Or you could use "ulimit -m" to set the RSS, of course.

I don't think that would do anything with 2.6 :P

#6 lore raw
In reply to [email protected]

Hi!

Quoted 4 lines
Quoted 3 lines

I have some lingvistics application here that is pretty demanding... it eats a lot of memory, overloads disk, and basically makes system unusable for even as simple tasks as reading maillists.

Quoted 8 lines
Quoted 1 line

Where are lastest versions of disk-prio and sched-idle patches?

The most likely culprit here is "eats memory". What's almost certainly happening is that your application is using a lot of pages, and leaving the system in thrashing mode. Quite likely, "sched-idle" won't do what you want, as all that will happen is that the application will dirty pages while the CPU is otherwise idle (and cause the same problem you're seeing already).

Well, problem is that it takes long even to awake galeon after you have not used it for few seconds. Disk is utilized by galeon at this point, and disk-prio + sched-idle should guarantee that when I ask system to do something, it will do it at max possible performance.

Quoted 7 lines

A better bet would be a patch that allowed you to set the maximum RSS size for the process so it can basically thrash itself while leaving enough memory for everybody else (and yes, I *know* how this can be self-defeating if the thrashing app then increases the total I/O consumed to be higher than the I/O bandwidth available - the point is that it's probably the high RSS value for his application causing OTHER things to thrash that's the root cause of his performance problem).

Is there effective way to limit RSS?
Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#7 lore raw
Quoted 1 line · Pavel Machek

Is there effective way to limit RSS?

Want me to port the RSS stuff from 2.4-rmap to 2.6 ?

Signature · 3 lines
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
#8 lore raw

Hi!

Quoted 3 lines
Quoted 1 line

Is there effective way to limit RSS?

Want me to port the RSS stuff from 2.4-rmap to 2.6 ?

Well, if it allows me to limit memory for one task so that it does not make system unusable... yes, that would be great.
Pavel

Signature · 1 line
When do you have heart between your knees?
#4 lore raw
In reply to Nick Piggin
Quoted 16 lines · Nick Piggin
Quoted 12 lines · Bill Davidsen
Quoted 7 lines · [email protected] wrote:

A better bet would be a patch that allowed you to set the maximum RSS size for the process so it can basically thrash itself while leaving enough memory for everybody else (and yes, I *know* how this can be self-defeating if the thrashing app then increases the total I/O consumed to be higher than the I/O bandwidth available - the point is that it's probably the high RSS value for his application causing OTHER things to thrash that's the root cause of his performance problem).

Quoted 5 lines
Quoted 1 line

Or you could use "ulimit -m" to set the RSS, of course.

I don't think that would do anything with 2.6 :P

Does that imply that the feature doesn't function as documented in 2.6? Or is that a SysV-ism not in SuS and documented but not implemented, or what other reason would there be for it to not work?

Signature · 3 lines
bill davidsen <[email protected]>
  CTO TMR Associates, Inc
  Doing interesting things with small computers since 1979
#5 lore raw
Quoted 12 lines · Bill Davidsen
Quoted 10 lines · Nick Piggin
Quoted 2 lines · Bill Davidsen

Or you could use "ulimit -m" to set the RSS, of course.

Quoted 5 lines
Quoted 1 line

I don't think that would do anything with 2.6 :P

Does that imply that the feature doesn't function as documented in 2.6? Or is that a SysV-ism not in SuS and documented but not implemented, or what other reason would there be for it to not work?

The first one. AFAIKS ulimit RSS doesn't do anything in the 2.6 vm.

Rik has a fairly straightforward looking implementation in his 2.4 vm which probably wouldn't be too hard to forward port. It doesn't impose a hard limit on RSS though: I'm not sure what the standards say about that.

#9 lore raw
In reply to Pavel Machek
Quoted 6 lines · Pavel Machek
Quoted 3 lines
Quoted 1 line

Is there effective way to limit RSS?

Want me to port the RSS stuff from 2.4-rmap to 2.6 ?

Well, if it allows me to limit memory for one task so that it does not make system unusable... yes, that would be great.

Here it is. Untested, except for whether it compiles cleanly ;)

Let me know how it works, if the enforcement is aggressive enough or not, whether I need to tweak things etc...

Signature · 168 lines
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan



===== include/linux/init_task.h 1.27 vs edited =====
--- 1.27/include/linux/init_task.h	Mon Aug 18 22:46:23 2003
+++ edited/include/linux/init_task.h	Tue Jan 20 17:34:40 2004
@@ -2,6 +2,7 @@
 #define _LINUX__INIT_TASK_H
 
 #include <linux/file.h>
+#include <asm/resource.h>
 
 #define INIT_FILES \
 { 							\
@@ -41,6 +42,7 @@
 	.page_table_lock =  SPIN_LOCK_UNLOCKED, 		\
 	.mmlist		= LIST_HEAD_INIT(name.mmlist),		\
 	.default_kioctx = INIT_KIOCTX(name.default_kioctx, name),	\
+	.rlimit_rss	= RLIM_INFINITY			\
 }
 
 #define INIT_SIGNALS(sig) {	\
===== include/linux/sched.h 1.178 vs edited =====
--- 1.178/include/linux/sched.h	Mon Jan 19 18:38:15 2004
+++ edited/include/linux/sched.h	Tue Jan 20 17:32:56 2004
@@ -204,6 +204,7 @@
 	unsigned long arg_start, arg_end, env_start, env_end;
 	unsigned long rss, total_vm, locked_vm;
 	unsigned long def_flags;
+	unsigned long rlimit_rss;
 	cpumask_t cpu_vm_mask;
 
 	unsigned long saved_auxv[40]; /* for /proc/PID/auxv */
===== include/linux/swap.h 1.80 vs edited =====
--- 1.80/include/linux/swap.h	Mon Jan 19 01:28:35 2004
+++ edited/include/linux/swap.h	Tue Jan 20 18:16:28 2004
@@ -179,7 +179,7 @@
 
 /* linux/mm/rmap.c */
 #ifdef CONFIG_MMU
-int FASTCALL(page_referenced(struct page *));
+int FASTCALL(page_referenced(struct page *, int *));
 struct pte_chain *FASTCALL(page_add_rmap(struct page *, pte_t *,
 					struct pte_chain *));
 void FASTCALL(page_remove_rmap(struct page *, pte_t *));
@@ -188,7 +188,7 @@
 /* linux/mm/shmem.c */
 extern int shmem_unuse(swp_entry_t entry, struct page *page);
 #else
-#define page_referenced(page)	TestClearPageReferenced(page)
+#define page_referenced(page, _x)	TestClearPageReferenced(page)
 #define try_to_unmap(page)	SWAP_FAIL
 #endif /* CONFIG_MMU */
 
===== kernel/sys.c 1.69 vs edited =====
--- 1.69/kernel/sys.c	Mon Jan 19 18:38:13 2004
+++ edited/kernel/sys.c	Tue Jan 20 18:02:19 2004
@@ -1308,6 +1308,14 @@
 	if (retval)
 		return retval;
 
+	/* The rlimit is specified in bytes, convert to pages for mm. */
+	if (resource == RLIMIT_RSS && current->mm) {
+		unsigned long pages = RLIM_INFINITY;
+		if (new_rlim.rlim_cur != RLIM_INFINITY)
+			pages = new_rlim.rlim_cur >> PAGE_SHIFT;
+		current->mm->rlimit_rss = pages;
+	}
+
 	*old_rlim = new_rlim;
 	return 0;
 }
===== mm/rmap.c 1.34 vs edited =====
--- 1.34/mm/rmap.c	Mon Jan 19 01:36:00 2004
+++ edited/mm/rmap.c	Tue Jan 20 18:26:03 2004
@@ -104,6 +104,7 @@
 /**
  * page_referenced - test if the page was referenced
  * @page: the page to test
+ * rsslimit: set if the process(es) using the page is(are) over RSS limit
  *
  * Quick test_and_clear_referenced for all mappings to a page,
  * returns the number of processes which referenced the page.
@@ -112,8 +113,9 @@
  * If the page has a single-entry pte_chain, collapse that back to a PageDirect
  * representation.  This way, it's only done under memory pressure.
  */
-int page_referenced(struct page * page)
+int page_referenced(struct page * page, int * rsslimit)
 {
+	struct mm_struct * mm;
 	struct pte_chain *pc;
 	int referenced = 0;
 
@@ -127,10 +129,17 @@
 		pte_t *pte = rmap_ptep_map(page->pte.direct);
 		if (ptep_test_and_clear_young(pte))
 			referenced++;
+
+		mm = ptep_to_mm(pte);
+		if (mm->rss > mm->rlimit_rss)
+			*rsslimit = 1;
 		rmap_ptep_unmap(pte);
 	} else {
 		int nr_chains = 0;
 
+		/* We clear it if any task using the page is under its limit. */
+		*rsslimit = 1;
+
 		/* Check all the page tables mapping this page. */
 		for (pc = page->pte.chain; pc; pc = pte_chain_next(pc)) {
 			int i;
@@ -142,6 +151,10 @@
 				p = rmap_ptep_map(pte_paddr);
 				if (ptep_test_and_clear_young(p))
 					referenced++;
+
+				mm = ptep_to_mm(p);
+				if (mm->rss < mm->rlimit_rss)
+					*rsslimit = 0;
 				rmap_ptep_unmap(p);
 				nr_chains++;
 			}
===== mm/vmscan.c 1.177 vs edited =====
--- 1.177/mm/vmscan.c	Mon Jan 19 18:38:07 2004
+++ edited/mm/vmscan.c	Wed Jan 21 14:34:44 2004
@@ -250,6 +250,7 @@
 	LIST_HEAD(ret_pages);
 	struct pagevec freed_pvec;
 	int pgactivate = 0;
+	int over_rsslimit;
 	int ret = 0;
 
 	cond_resched();
@@ -278,10 +279,12 @@
 			goto keep_locked;
 
 		pte_chain_lock(page);
-		referenced = page_referenced(page);
+		referenced = page_referenced(page, &over_rsslimit);
 		if (referenced && page_mapping_inuse(page)) {
 			/* In active use or really unfreeable.  Activate it. */
 			pte_chain_unlock(page);
+			if (over_rsslimit)
+				goto keep_locked;
 			goto activate_locked;
 		}
 
@@ -597,6 +600,7 @@
 	long mapped_ratio;
 	long distress;
 	long swap_tendency;
+	int over_rsslimit;
 
 	lru_add_drain();
 	pgmoved = 0;
@@ -657,7 +661,7 @@
 		list_del(&page->lru);
 		if (page_mapped(page)) {
 			pte_chain_lock(page);
-			if (page_mapped(page) && page_referenced(page)) {
+			if (page_mapped(page) && page_referenced(page, &over_rsslimit) && !over_rsslimit) {
 				pte_chain_unlock(page);
 				list_add(&page->lru, &l_active);
 				continue;
#10 lore raw

Hi!

Quoted 11 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Is there effective way to limit RSS?

Want me to port the RSS stuff from 2.4-rmap to 2.6 ?

Well, if it allows me to limit memory for one task so that it does not make system unusable... yes, that would be great.

Here it is. Untested, except for whether it compiles cleanly ;)

Let me know how it works, if the enforcement is aggressive enough or not, whether I need to tweak things etc...

It boots, and seems to have no ill effects. I've yet to see some good effects, too...

doing

ulimit -m 1
<some task>

should make that task run with extremely low priority, right?

Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#11 lore raw
Quoted 6 lines · Pavel Machek

doing

ulimit -m 1
<some task>

should make that task run with extremely low priority, right?

Yeah, when the box is under memory pressure, pages from that task should never hit the active list. Instead, they should always stay on the inactive list and the non-referenced pages from that app should get reclaimed.

OTOH, if the app keeps referencing all pages, maybe I need to tune up the aggressiveness a bit and also reclaim the referenced pages ... if the current patch doesn't work right I'll make a more aggressive one.

Note that RSS limit enforcement is always lazy, because otherwise the RSS limited task will hog the IO subsystem full-time and slow everything else down ... even when there's more than enough memory.

Signature · 3 lines
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
#12 lore raw

Hi!

Quoted 10 lines
Quoted 4 lines

ulimit -m 1
<some task>

should make that task run with extremely low priority, right?

Yeah, when the box is under memory pressure, pages from that task should never hit the active list. Instead, they should always stay on the inactive list and the non-referenced pages from that app should get reclaimed.

Quoted 4 lines

OTOH, if the app keeps referencing all pages, maybe I need to tune up the aggressiveness a bit and also reclaim the referenced pages ... if the current patch doesn't work right I'll make a more aggressive one.

I'm afraid it needs to be more aggressive.

I made two programs, each walking over 150MB of memory, and ran them at same time on 250MB machine. One of them with ulimit -m 1... Both got about the same ammount of RAM and progressed at similar speed.

Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#13 lore raw
Quoted 1 line · Pavel Machek

I'm afraid it needs to be more aggressive.

OK, is the patch below any better ?

Signature · 163 lines
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

===== include/linux/init_task.h 1.27 vs edited =====
--- 1.27/include/linux/init_task.h	Mon Aug 18 22:46:23 2003
+++ edited/include/linux/init_task.h	Tue Jan 20 17:34:40 2004
@@ -2,6 +2,7 @@
 #define _LINUX__INIT_TASK_H
 
 #include <linux/file.h>
+#include <asm/resource.h>
 
 #define INIT_FILES \
 { 							\
@@ -41,6 +42,7 @@
 	.page_table_lock =  SPIN_LOCK_UNLOCKED, 		\
 	.mmlist		= LIST_HEAD_INIT(name.mmlist),		\
 	.default_kioctx = INIT_KIOCTX(name.default_kioctx, name),	\
+	.rlimit_rss	= RLIM_INFINITY			\
 }
 
 #define INIT_SIGNALS(sig) {	\
===== include/linux/sched.h 1.178 vs edited =====
--- 1.178/include/linux/sched.h	Mon Jan 19 18:38:15 2004
+++ edited/include/linux/sched.h	Tue Jan 20 17:32:56 2004
@@ -204,6 +204,7 @@
 	unsigned long arg_start, arg_end, env_start, env_end;
 	unsigned long rss, total_vm, locked_vm;
 	unsigned long def_flags;
+	unsigned long rlimit_rss;
 	cpumask_t cpu_vm_mask;
 
 	unsigned long saved_auxv[40]; /* for /proc/PID/auxv */
===== include/linux/swap.h 1.80 vs edited =====
--- 1.80/include/linux/swap.h	Mon Jan 19 01:28:35 2004
+++ edited/include/linux/swap.h	Tue Jan 20 18:16:28 2004
@@ -179,7 +179,7 @@
 
 /* linux/mm/rmap.c */
 #ifdef CONFIG_MMU
-int FASTCALL(page_referenced(struct page *));
+int FASTCALL(page_referenced(struct page *, int *));
 struct pte_chain *FASTCALL(page_add_rmap(struct page *, pte_t *,
 					struct pte_chain *));
 void FASTCALL(page_remove_rmap(struct page *, pte_t *));
@@ -188,7 +188,7 @@
 /* linux/mm/shmem.c */
 extern int shmem_unuse(swp_entry_t entry, struct page *page);
 #else
-#define page_referenced(page)	TestClearPageReferenced(page)
+#define page_referenced(page, _x)	TestClearPageReferenced(page)
 #define try_to_unmap(page)	SWAP_FAIL
 #endif /* CONFIG_MMU */
 
===== kernel/sys.c 1.69 vs edited =====
--- 1.69/kernel/sys.c	Mon Jan 19 18:38:13 2004
+++ edited/kernel/sys.c	Tue Jan 20 18:02:19 2004
@@ -1308,6 +1308,14 @@
 	if (retval)
 		return retval;
 
+	/* The rlimit is specified in bytes, convert to pages for mm. */
+	if (resource == RLIMIT_RSS && current->mm) {
+		unsigned long pages = RLIM_INFINITY;
+		if (new_rlim.rlim_cur != RLIM_INFINITY)
+			pages = new_rlim.rlim_cur >> PAGE_SHIFT;
+		current->mm->rlimit_rss = pages;
+	}
+
 	*old_rlim = new_rlim;
 	return 0;
 }
===== mm/rmap.c 1.34 vs edited =====
--- 1.34/mm/rmap.c	Mon Jan 19 01:36:00 2004
+++ edited/mm/rmap.c	Tue Jan 20 18:26:03 2004
@@ -104,6 +104,7 @@
 /**
  * page_referenced - test if the page was referenced
  * @page: the page to test
+ * rsslimit: set if the process(es) using the page is(are) over RSS limit
  *
  * Quick test_and_clear_referenced for all mappings to a page,
  * returns the number of processes which referenced the page.
@@ -112,8 +113,9 @@
  * If the page has a single-entry pte_chain, collapse that back to a PageDirect
  * representation.  This way, it's only done under memory pressure.
  */
-int page_referenced(struct page * page)
+int page_referenced(struct page * page, int * rsslimit)
 {
+	struct mm_struct * mm;
 	struct pte_chain *pc;
 	int referenced = 0;
 
@@ -127,10 +129,17 @@
 		pte_t *pte = rmap_ptep_map(page->pte.direct);
 		if (ptep_test_and_clear_young(pte))
 			referenced++;
+
+		mm = ptep_to_mm(pte);
+		if (mm->rss > mm->rlimit_rss)
+			*rsslimit = 1;
 		rmap_ptep_unmap(pte);
 	} else {
 		int nr_chains = 0;
 
+		/* We clear it if any task using the page is under its limit. */
+		*rsslimit = 1;
+
 		/* Check all the page tables mapping this page. */
 		for (pc = page->pte.chain; pc; pc = pte_chain_next(pc)) {
 			int i;
@@ -142,6 +151,10 @@
 				p = rmap_ptep_map(pte_paddr);
 				if (ptep_test_and_clear_young(p))
 					referenced++;
+
+				mm = ptep_to_mm(p);
+				if (mm->rss < mm->rlimit_rss)
+					*rsslimit = 0;
 				rmap_ptep_unmap(p);
 				nr_chains++;
 			}
===== mm/vmscan.c 1.177 vs edited =====
--- 1.177/mm/vmscan.c	Mon Jan 19 18:38:07 2004
+++ edited/mm/vmscan.c	Fri Jan 23 14:00:48 2004
@@ -250,6 +250,7 @@
 	LIST_HEAD(ret_pages);
 	struct pagevec freed_pvec;
 	int pgactivate = 0;
+	int over_rsslimit;
 	int ret = 0;
 
 	cond_resched();
@@ -278,8 +279,8 @@
 			goto keep_locked;
 
 		pte_chain_lock(page);
-		referenced = page_referenced(page);
-		if (referenced && page_mapping_inuse(page)) {
+		referenced = page_referenced(page, &over_rsslimit);
+		if (referenced && page_mapping_inuse(page) && !over_rsslimit) {
 			/* In active use or really unfreeable.  Activate it. */
 			pte_chain_unlock(page);
 			goto activate_locked;
@@ -597,6 +598,7 @@
 	long mapped_ratio;
 	long distress;
 	long swap_tendency;
+	int over_rsslimit;
 
 	lru_add_drain();
 	pgmoved = 0;
@@ -657,7 +659,7 @@
 		list_del(&page->lru);
 		if (page_mapped(page)) {
 			pte_chain_lock(page);
-			if (page_mapped(page) && page_referenced(page)) {
+			if (page_mapped(page) && page_referenced(page, &over_rsslimit) && !over_rsslimit) {
 				pte_chain_unlock(page);
 				list_add(&page->lru, &l_active);
 				continue;
#14 lore raw

Hi!

Quoted 3 lines
Quoted 1 line

I'm afraid it needs to be more aggressive.

OK, is the patch below any better ?

Yes, this one actually works. When I launched two 150MB tasks, one of them with ulimit -m 1, the limited task yielded its memory to unlimited one. It worked as expected.
Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#17 lore raw
In reply to Rik van Riel
Quoted 7 lines · Rik van Riel
Quoted 1 line · Pavel Machek

Is there effective way to limit RSS?

Want me to port the RSS stuff from 2.4-rmap to 2.6 ?

What's the effort? It's useful for programs which use a lot of memory, particularly for those which only do it on some data sets. It would certainly act as a safty net.

Signature · 3 lines
bill davidsen <[email protected]>
  CTO TMR Associates, Inc
  Doing interesting things with small computers since 1979
#18 lore raw

Hi!

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Is there effective way to limit RSS?

Want me to port the RSS stuff from 2.4-rmap to 2.6 ?

What's the effort? It's useful for programs which use a lot of memory, particularly for those which only do it on some data sets. It would certainly act as a safty net.

If you have two apps which oth need lots of memory, and want to "renice" one to run slower.

Alternatively when you have one app eating a lots of memory and you want your system to remain usable.
Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#15 lore raw
In reply to Pavel Machek

In article <[email protected]>,
Pavel Machek <[email protected]> wrote:

| > > I'm afraid it needs to be more aggressive.
| > 
| > OK, is the patch below any better ?
| 
| Yes, this one actually works. When I launched two 150MB tasks, one of
| them with ulimit -m 1, the limited task yielded its memory to
| unlimited one. It worked as expected.

I'm not sure what "as expected" means with this small a limit, hopefully not "pages its butt off." I am printing a hardcopy of the 2nd patch and a bit of the surrounding code, and also compiling a new kernel with the patch in place, so I can play a bit in the morning.

I also wonder if a sanity check is desirable on the minimum size. At some point I would think the system would get a lot of overhead trying to actually use a single 1k page :-(

Thanks for this prompt implementation, I do have a few applications which can use it!

Signature · 3 lines
bill davidsen <[email protected]>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.
#16 lore raw

Hi!

Quoted 8 lines
| > > I'm afraid it needs to be more aggressive.
| > 
| > OK, is the patch below any better ?
| 
| Yes, this one actually works. When I launched two 150MB tasks, one of
| them with ulimit -m 1, the limited task yielded its memory to
| unlimited one. It worked as expected.
Quoted 4 lines

I'm not sure what "as expected" means with this small a limit, hopefully not "pages its butt off." I am printing a hardcopy of the 2nd patch and a bit of the surrounding code, and also compiling a new kernel with the patch in place, so I can play a bit in the morning.

Well, it should mean "all the memory from this process should be reclaimed if it is needed".

Quoted 3 lines

I also wonder if a sanity check is desirable on the minimum size. At some point I would think the system would get a lot of overhead trying to actually use a single 1k page :-(

I believe it is okay as is. It just gives it very low "memory-priority".

Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]