-mm5 has no i2c on amd64

PATCH Andi Kleen 4 participants 5 messages Jan 20, 2004 – Jan 21, 2004 1 message not in the archive

lore

Share & tools

lore

Andi Kleen

author

2004-01-20 17:47 UTC #1 lore raw

In reply to a message not in the archive

arch/x86_64/Kconfig line 433

Quoted 10 lines · Gerd Knorr

==============================[ cut here ]==============================
arch/x86_64/Kconfig renamed from arch/x86_64/Kconfig.i2c +2 -0
@@ -429,6 +429,8 @@
 
 source "drivers/char/Kconfig"
 
+source "drivers/i2c/Kconfig"
+

There is no such source in arch/i386/Kconfig. So it's probably wrong.

-Andi

Andrew Morton

2004-01-20 18:19 UTC #2 lore raw

Quoted 8 lines · Andi Kleen

Quoted 6 lines · Gerd Knorr
==============================[ cut here ]==============================
arch/x86_64/Kconfig renamed from arch/x86_64/Kconfig.i2c +0 -0
@@ -429,6 +429,8 @@
 

Quoted 7 lines

arch/x86_64/Kconfig line 433
Quoted 4 lines
arch/x86_64/Kconfig renamed from arch/x86_64/Kconfig.i2c +2 -0
 source "drivers/char/Kconfig"
 
+source "drivers/i2c/Kconfig"
+
There is no such source in arch/i386/Kconfig. So it's probably wrong.

arch/i386/Kconfig sources drivers/Kconfig, which then picks up the i2c stuff.

Gerd Knorr

2004-01-20 18:45 UTC #3 lore raw

In reply to Andi Kleen

Quoted 7 lines · Andi Kleen

Review
Quoted 4 lines · Gerd Knorr
+++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
(quoted diff) +2 -0
+source "drivers/i2c/Kconfig"
+
There is no such source in arch/i386/Kconfig. So it's probably wrong.

i386 includes that indirectly via drivers/Kconfig
So should the other archs do that too?

Gerd

Signature · 1 line

"... und auch das ganze Wochenende oll" -- Wetterbericht auf RadioEins

Andi Kleen

author

2004-01-20 18:52 UTC #4 lore raw

Quoted 11 lines · On Tue, 20 Jan 2004 19:32:59 +0100 Gerd Knorr <[email protected]> wrote:

Quoted 7 lines · Andi Kleen
Review
Quoted 4 lines · Gerd Knorr
+++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
(quoted diff) +2 -0
+source "drivers/i2c/Kconfig"
+
There is no such source in arch/i386/Kconfig. So it's probably wrong.
i386 includes that indirectly via drivers/Kconfig
So should the other archs do that too?

Yep. Or at least x86-64 should likely.

But it must have worked until recently because I got a report about I2C on x86-64 for 2.6.0.

-Andi

Greg KH

2004-01-21 00:31 UTC #5 lore raw

Quoted 12 lines · Andi Kleen

Quoted 9 lines · On Tue, 20 Jan 2004 19:32:59 +0100 Gerd Knorr <[email protected]> wrote:
Quoted 7 lines · Andi Kleen
Review
Quoted 4 lines · Gerd Knorr
+++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
(quoted diff) +2 -0
+source "drivers/i2c/Kconfig"
+
There is no such source in arch/i386/Kconfig. So it's probably wrong.

Quoted 6 lines

Quoted 2 lines
i386 includes that indirectly via drivers/Kconfig
So should the other archs do that too?
Yep. Or at least x86-64 should likely.
But it must have worked until recently because I got a report about I2C on x86-64 for 2.6.0.

Yes, I just moved the i2c Kconfig out of the char menu, and into the main drivers/Kconfig.

And here I thought all of the archs had switched to using that file, instead of trying to put together their own drivers menus :)

thanks,

greg k-h