Skip to contentSkip to conversation

[2.4] invalid kfree in ntfs_printcb

PATCH Herbert Xu 3 participants 5 messages Jan 31, 2004 – Feb 15, 2004 NTFS filesystem

lore
Share & tools
lore

Herbert Xu

author
#0 lore raw

Hi:

This patch fixes a potential double kfree in ntfs_printcb in 2.4.24.

Cheers,

Signature · 4 lines
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Index: kernel-2.4/fs/ntfs/fs.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.4/fs/ntfs/fs.c,v retrieving revision 1.1.1.15

fs/ntfs/fs.c +3 -2
diff -u -r1.1.1.15 fs.c
@@ -199,7 +199,7 @@
 		ntfs_debug(DEBUG_OTHER, "%s(): Skipping unrepresentable "
 				"file.\n", __FUNCTION__);
 		err = 0;
-		goto err_ret;
+		goto err_noname;
 	}
 	if (!show_sys_files && inum < 0x10UL) {
 		ntfs_debug(DEBUG_OTHER, "%s(): Skipping system file (%s).\n",
@@ -233,8 +233,9 @@
 	if (err)
 		nf->ret_code = err;
 err_ret:
-	nf->namelen = 0;
 	ntfs_free(nf->name);
+err_noname:
+	nf->namelen = 0;
 	nf->name = NULL;
 	return err;
 }
author
#1 lore raw

[2.4] off-by-one kmalloc in ntfs

This patch fixes an off-by-one kmalloc bug in ntfs in 2.4.24.

Cheers,

Signature · 4 lines
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Index: kernel-2.4/fs/ntfs/support.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.4/fs/ntfs/support.c,v retrieving revision 1.1.1.9

fs/ntfs/support.c +1 -1
diff -u -r1.1.1.9 support.c
@@ -240,7 +240,7 @@
 				NLS_MAX_CHARSET_SIZE)) > 0) {
 			/* Adjust result buffer. */
 			if (chl > 1) {
-				buf = ntfs_malloc(*out_len + chl - 1);
+				buf = ntfs_malloc(*out_len + chl);
 				if (!buf) {
 					i = -ENOMEM;
 					goto err_ret;
#2 lore raw

Re: [Linux-NTFS-Dev] [2.4] off-by-one kmalloc in ntfs

Quoted 1 line · Herbert Xu

This patch fixes an off-by-one kmalloc bug in ntfs in 2.4.24.

Thanks for your time fixing bugs in the legacy driver.

May I be interested in your motivations? Recently there is a clear flow of RedHat refugees to Debian and if you would like better NTFS support then perhaps Debian should use the backport of the rewritten NTFS driver too, just like all other distros do who care about NTFS support.

You can find some of the differences between the legacy (in vanilla 2.4) and the Linux-NTFS project's NTFS driver (it's in in 2.6 and there is a backport maintained for 2.4):

http://linux-ntfs.sourceforge.net/status.html

Besides the several drawbacks vanila 2.4 driver has, I'm aware of only two features it's capable but not the rewritten one:

- NTFS can be exported via NFS. This came without any work but it would need some time to support with the new driver. There was one request for this feature in the last two years so it's not the highest priority

- one can trash his/her NTFS or the box (the legacy diver is not SMP, reentrant safe). AFAIK, no plan to add this feature to the new driver neither in the short nor in long term.

Szaka

#3 lore raw

Re: [Linux-NTFS-Dev] [2.4] off-by-one kmalloc in ntfs

Quoted 13 lines · Szakacsits Szabolcs
Quoted 1 line · Herbert Xu

This patch fixes an off-by-one kmalloc bug in ntfs in 2.4.24.

Thanks for your time fixing bugs in the legacy driver.

May I be interested in your motivations? Recently there is a clear flow of RedHat refugees to Debian and if you would like better NTFS support then perhaps Debian should use the backport of the rewritten NTFS driver too, just like all other distros do who care about NTFS support.

You can find some of the differences between the legacy (in vanilla 2.4) and the Linux-NTFS project's NTFS driver (it's in in 2.6 and there is a backport maintained for 2.4):

Quoted 8 lines

http://linux-ntfs.sourceforge.net/status.html

Besides the several drawbacks vanila 2.4 driver has, I'm aware of only two features it's capable but not the rewritten one:

- NTFS can be exported via NFS. This came without any work but it would need some time to support with the new driver. There was one request for this feature in the last two years so it's not the highest priority

The to be released NTFS 2.0.7 for 2.6 kernel adds support for exporting via NFS. (-: Unfortunately last week the hd at my computer at work blew up so I didn't get round to doing my final testing so I haven't officially released 2.0.7 yet but hopefully I will release it next week. Assuming 2.4 now uses the same mechanism for exporting via NFS (I am not sure if the 2.6 changes were backported or not) it will be easy to update the NTFS backport with this feature.

Quoted 3 lines

- one can trash his/her NTFS or the box (the legacy diver is not SMP, reentrant safe). AFAIK, no plan to add this feature to the new driver neither in the short nor in long term.

Yes, most definitely we have no intention of implementing that feature in the new driver! (-:

Best regards,

Anton

Signature · 4 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
#4 lore raw

Re: [Linux-NTFS-Dev] [2.4] off-by-one kmalloc in ntfs

Quoted 16 lines · Anton Altaparmakov
Quoted 15 lines · Szakacsits Szabolcs
Quoted 1 line · Herbert Xu

This patch fixes an off-by-one kmalloc bug in ntfs in 2.4.24.

Thanks for your time fixing bugs in the legacy driver.

May I be interested in your motivations? Recently there is a clear flow of RedHat refugees to Debian and if you would like better NTFS support then perhaps Debian should use the backport of the rewritten NTFS driver too, just like all other distros do who care about NTFS support.

You can find some of the differences between the legacy (in vanilla 2.4) and the Linux-NTFS project's NTFS driver (it's in in 2.6 and there is a backport maintained for 2.4):

http://linux-ntfs.sourceforge.net/status.html

Quoted 8 lines
Quoted 6 lines

Besides the several drawbacks vanila 2.4 driver has, I'm aware of only two features it's capable but not the rewritten one:

- NTFS can be exported via NFS. This came without any work but it would need some time to support with the new driver. There was one request for this feature in the last two years so it's not the highest priority

The to be released NTFS 2.0.7 for 2.6 kernel adds support for exporting

oops, I meant 2.1.7

Quoted 3 lines

via NFS. (-: Unfortunately last week the hd at my computer at work blew up so I didn't get round to doing my final testing so I haven't officially released 2.0.7 yet but hopefully I will release it next week. Assuming

and again 2.1.7

Quoted 8 lines

2.4 now uses the same mechanism for exporting via NFS (I am not sure if the 2.6 changes were backported or not) it will be easy to update the NTFS backport with this feature.

Quoted 3 lines

- one can trash his/her NTFS or the box (the legacy diver is not SMP, reentrant safe). AFAIK, no plan to add this feature to the new driver neither in the short nor in long term.

Quoted 7 lines

Yes, most definitely we have no intention of implementing that feature in the new driver! (-:

Best regards,

Anton

Best regards,

Anton

Signature · 4 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/