Skip to contentSkip to conversation

[[email protected]: Re: ANNOUNCE: megaraid driver version 2.10.1]

[email protected]: Re: ANNOUNCE: megaraid driver version 2.10.1 '[email protected]' 1 participant 1 message Feb 1, 2004 SCSI

lore
Share & tools
lore
#0 lore raw

sorry, forgot to Cc the list when replying.

----- Forwarded message from "'[email protected]'" <[email protected]> -----

Date: Sun, 1 Feb 2004 15:46:11 +0000
From: "'[email protected]'" <[email protected]>
Subject: Re: ANNOUNCE: megaraid driver version 2.10.1
To: "Mukker, Atul" <[email protected]>

Quoted 5 lines · Atul

Hello Christoph,

I am in process of testing the next version of the megaraid driver. I faced an issue while doing the insmod-rmmod sequence. Your patch for PCI hotplug does "pci_disable_device" when the driver is unloaded.

Yupp.

Quoted 3 lines

The insmod-rmmod-insmod fails the first time unless you do an explicit pci_set_master at driver load time, since pci_enable_device does not seem to enable bus mastering, which is disabled by pci_disable_device.

Right, we need the pci_set_master anyway because it's not guaranteed to be enabled even when loading the first time. (although it usually is on PC hardware). I'll send a patch to jejb to fix it ASAP, but you should add it to the 2.4 driver aswell.

Quoted 6 lines

Even with pci_set_master, insmod stalls the CPU after about 2-3 hours of insmod-rmmod sequence. So I took out the pci_disable_device altogether to find out it takes only longer, about 9 hours, but CPU stalls at the exact location again with a NMI watchdog. It happens when the driver issues the first command to the FW, which is never received by it and driver gets stuck in a forever cpu_relax loop waiting for the command to complete

Well, you're not supposed to unload/reload all the time because for example the scsi host number is never incremented. I can really explain the hang, though. Maybe you'll get the host number of a HBA driven by another driver because we don't have overflow checking? I need to fix that anyway..

Quoted 1 line

The kernel is a genre of 2.4.21

Huh? I don't see how the PCI hotplugging changes work with a 2.4 scsi midlayer..

----- End forwarded message -----

Signature · 2 lines
Christoph Hellwig <[email protected]>		-	Freelance Hacker
Contact me for driver hacking and kernel development consulting