Skip to contentSkip to conversation

Strange problem with emu10k1 and gcc-3.4

PATCH J.A. Magallon 2 participants 3 messages Feb 12, 2004 – Feb 13, 2004

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi al...

I have tried to build 2.6.3-rc2-mm1 with gcc-3.4, and it works apart from this:

werewolf:/boot# modprobe emu10k1
FATAL: Error inserting emu10k1 (/lib/modules/2.6.3-rc1-jam1-gcc34/kernel/sound/oss/emu10k1/emu10k1.ko): Unknown symbol in module, or unknown parameter (see dmesg)

dmesg:
...
emu10k1: Unknown symbol strcpy

I think this solves the problem:

sound/oss/emu10k1/efxmgr.h renamed from sound/oss/emu10k1/efxmgr.h.orig +2 -0
@@ -32,6 +32,8 @@
 #ifndef _EFXMGR_H
 #define _EFXMGR_H
 
+#include <linux/string.h>
+
 struct emu_efx_info_t{
 	int opcode_shift;
 	int high_operand_shift;

The strange thing is: why depmod -ae does not show any problem ?

TIA

Signature · 4 lines
J.A. Magallon <jamagallon()able!es>     \                 Software is like sex:
werewolf!able!es                         \           It's better when it's free
Mandrake Linux release 10.0 (Cooker) for i586
Linux 2.6.3-rc1-jam1-gcc34 (gcc 3.4.0 (Mandrake Linux 10.0 3.4.0-0.1mdk))
#1 lore raw
Quoted 4 lines · J.A. Magallon

Hi al...

I have tried to build 2.6.3-rc2-mm1 with gcc-3.4, and it works apart from this:

Quoted 9 lines
werewolf:/boot# modprobe emu10k1
FATAL: Error inserting emu10k1 (/lib/modules/2.6.3-rc1-jam1-gcc34/kernel/sound/oss/emu10k1/emu10k1.ko): Unknown symbol in module, or unknown parameter (see dmesg)

dmesg:
...
emu10k1: Unknown symbol strcpy

I think this solves the problem:

Nope, that was not enough. Any ideas ?

Signature · 4 lines
J.A. Magallon <jamagallon()able!es>     \                 Software is like sex:
werewolf!able!es                         \           It's better when it's free
Mandrake Linux release 10.0 (Cooker) for i586
Linux 2.6.3-rc2-jam1 (gcc 3.4.0 (Mandrake Linux 10.0 3.4.0-0.1mdk))
#2 lore raw
In reply to J.A. Magallon
Quoted 3 lines · J.A. Magallon

Hi al...

I have tried to build 2.6.3-rc2-mm1 with gcc-3.4, and it works apart from thi

s:

Quoted 2 lines

emu10k1: Unknown symbol strcpy

Alternate fix for a similar problem I hit is appended. Basically, if gcc-3.4 fails to inline all of them, we need to have a copy that's visible from a module.

(Oh, the '#undef memcmp' was needed because memcmp was #defined to __inline_memcmp so the wrong thing got EXPORT_SYMBOL'ed...)

I'll submit an extended patch that does all of string.c if people think it's a good idea.

lib/string.c renamed from lib/string.c.dist +4 -0
@@ -501,6 +501,9 @@
 #endif
 
 #ifndef __HAVE_ARCH_MEMCMP
+#ifdef memcmp
+#undef memcmp
+#endif
 /**
  * memcmp - Compare two areas of memory
  * @cs: One area of memory
@@ -517,6 +520,7 @@
 			break;
 	return res;
 }
+EXPORT_SYMBOL(memcmp);
 #endif
 
 #ifndef __HAVE_ARCH_MEMSCAN