Skip to contentSkip to conversation

2.4.24 link err for sparc64

PATCH carbonated beverage 2 participants 2 messages Feb 16, 2004 – Feb 17, 2004

lore
Share & tools
lore
#0 lore raw

Hi all,

I ripped out sysctl support from a 2.4.24 kernel (stock tarball from ftp.*.*.kernel.org) and the final link failed with:

arch/sparc64/kernel/kernel.o(.text+0x19750): In function `sys32_sysctl':
: undefined reference to `do_sysctl'

I tossed an #ifndef CONFIG_SYSCTL...#else...#endif guard around arch/sparc64/kernel/sys_sparc32.c file in the sys32_sysctl() function so it returns -ENOTSUPP, but I'm not sure that's the right fix. Should it be in do_sysctl() instead?

Can anyone comment on this?

sparc64/kernel/sys_sparc32.c renamed from sparc64/kernel/sys_sparc32.c.old +4 -0
@@ -4454,6 +4454,9 @@
 
 extern asmlinkage long sys32_sysctl(struct __sysctl_args32 *args)
 {
+#ifndef CONFIG_SYSCTL
+	return -ENOTSUPP;
+#else
 	struct __sysctl_args32 tmp;
 	int error;
 	size_t oldlen, *oldlenp = NULL;
@@ -4488,4 +4491,5 @@
 		copy_to_user(args->__unused, tmp.__unused, sizeof(tmp.__unused));
 	}
 	return error;
+#endif
 }

-- DN
Daniel

#1 lore raw
Quoted 6 lines · On Sun, 15 Feb 2004 23:29:29 -0800 carbonated beverage <[email protected]>…

I ripped out sysctl support from a 2.4.24 kernel (stock tarball from ftp.*.*.kernel.org) and the final link failed with:

arch/sparc64/kernel/kernel.o(.text+0x19750): In function `sys32_sysctl':
: undefined reference to `do_sysctl'

-ENOSYS is the right error to return, to be consistent with what kernel/sysctl.c itself does in this case.

Thanks for the report, I'll push the fix around.