Skip to contentSkip to conversation

kernel-smp on i386, too many arguments to function `aty128_find_mem_vbios'

DISCUSSION Olaf Hering 3 participants 3 messages Feb 16, 2004 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

CC [M] drivers/video/aty/radeon_base.o
drivers/video/aty/radeon_base.c: In function `radeon_screen_blank':
drivers/video/aty/radeon_base.c:945: warning: val2' might be used uninitialized in this function drivers/video/aty/radeon_base.c: In function radeonfb_setcolreg':
drivers/video/aty/radeon_base.c:1026: warning: vclk_cntl' might be used uninitialized in this function drivers/video/aty/radeon_base.c: In function radeonfb_set_par':
drivers/video/aty/radeon_base.c:1320: warning: `pll_output_freq' might be used uninitialized in this function
CC [M] drivers/video/aty/radeon_pm.o
CC [M] drivers/video/aty/radeon_monitor.o
drivers/video/aty/radeon_monitor.c: In function `radeon_match_mode':
drivers/video/aty/radeon_monitor.c:865: warning: passing arg 1 of `fb_validate_mode' discards qualifiers from pointer target type

  CC [M]  drivers/video/aty/radeon_accel.o
  CC [M]  drivers/video/aty/radeon_i2c.o
  LD [M]  drivers/video/aty/atyfb.o
  CC [M]  drivers/video/aty/aty128fb.o

drivers/video/aty/aty128fb.c: In function `aty128_probe':
drivers/video/aty/aty128fb.c:1955: error: too many arguments to function `aty128_find_mem_vbios' make[3]: *** [drivers/video/aty/aty128fb.o] Error 1
make[2]: *** [drivers/video/aty] Error 2
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

current bk.

Signature · 3 lines
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG
#1 lore raw
Quoted 16 lines · Olaf Hering

CC [M] drivers/video/aty/radeon_base.o
drivers/video/aty/radeon_base.c: In function `radeon_screen_blank':
drivers/video/aty/radeon_base.c:945: warning: val2' might be used uninitialized in this function drivers/video/aty/radeon_base.c: In function radeonfb_setcolreg':
drivers/video/aty/radeon_base.c:1026: warning: vclk_cntl' might be used uninitialized in this function drivers/video/aty/radeon_base.c: In function radeonfb_set_par':
drivers/video/aty/radeon_base.c:1320: warning: `pll_output_freq' might be used uninitialized in this function
CC [M] drivers/video/aty/radeon_pm.o
CC [M] drivers/video/aty/radeon_monitor.o
drivers/video/aty/radeon_monitor.c: In function `radeon_match_mode':
drivers/video/aty/radeon_monitor.c:865: warning: passing arg 1 of `fb_validate_mode' discards qualifiers from pointer target type

  CC [M]  drivers/video/aty/radeon_accel.o
  CC [M]  drivers/video/aty/radeon_i2c.o
  LD [M]  drivers/video/aty/atyfb.o
  CC [M]  drivers/video/aty/aty128fb.o
Quoted 6 lines

drivers/video/aty/aty128fb.c: In function `aty128_probe':
drivers/video/aty/aty128fb.c:1955: error: too many arguments to function `aty128_find_mem_vbios' make[3]: *** [drivers/video/aty/aty128fb.o] Error 1
make[2]: *** [drivers/video/aty] Error 2
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

Looks straightforward enough...

Dave

drivers/video/aty/aty128fb.c renamed from drivers/video/aty/aty128fb.c~ +1 -1
@@ -1952,7 +1952,7 @@
 	bios = aty128_map_ROM(par, pdev);
 #ifdef __i386__
 	if (bios == NULL)
-		bios = aty128_find_mem_vbios(par, pdev);
+		bios = aty128_find_mem_vbios(par);
 #endif
 	if (bios == NULL)
 		printk(KERN_INFO "aty128fb: BIOS not located, guessing timings.\n");
#2 lore raw
Quoted 3 lines

Looks straightforward enough...

Yes, sent a patch already. I tested building this function, but not building the function & the call to it :) (it's __i386__ and I'm on ppc). Sorry.

Ben.