patch for dlmalloc.c and cfi_flash.c
hi all,
attached is a patch for two different quick fixes.
dlmalloc: enable the debug data. instead of having #if0 everywhere,
replace with #ifdef DEBUG.
cfi_flash: i shared this patch with brad, and he asked i send it on.
he's going to try to find a better long-term solution. for the CFI interface to support little-endian, it does byte swapping. unfortunately, the byte-swapping was only coded for 16-bit width. this corrects the coding to be more "correct" and adds 32-bit support.
comments?
-josh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff.1
Type: application/octet-stream
Size: 2291 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040216/e889531a/attachment.obj
Wolfgang Denk
AppliedDear Josh,
Quoted 5 lines · in message <[email protected]> you wrote:
attached is a patch for two different quick fixes.
dlmalloc: enable the debug data. instead of having #if0 everywhere,
replace with #ifdef DEBUG.
I reject this part of the patch. Sorry. But the malloc code can be considered stable and well-tested. I think if you feel you are in a situation to need debug information from malloc you are already on a wrong track. I definitely don't want to flood the user with all the irrelevant malloc debug messages when he turns on the global DEBUG flag.
Quoted 6 lines
cfi_flash: i shared this patch with brad, and he asked i send it on.
he's going to try to find a better long-term solution. for the CFI interface to support little-endian, it does byte swapping. unfortunately, the byte-swapping was only coded for 16-bit width. this corrects the coding to be more "correct" and adds 32-bit support.
Applied. Thanks. [Ummm... please stick with the coding standards!!]
Best regards,
Wolfgang Denk
Signature · 5 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
Command, n.:
Statement presented by a human and accepted by a computer
in such a manner as to make the human feel as if he is in control.