Skip to contentSkip to conversation

Enable Intel AGP on x86-64

PATCH Dave Jones 2 participants 4 messages Feb 18, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw
Quoted 5 lines · Linux Kernel

ChangeSet 1.1564, 2004/02/18 11:44:38-08:00, [email protected]

[PATCH] Enable Intel AGP on x86-64

Enable the Intel AGP driver for x86-64 too.

Please don't do this. At least copy intel-agp.c to something new and throw out all the dozens of chipsets that will never appear on ia32e.

Splitting agpgart up to seperate drivers allowed us to stop adding cruft upon cruft with each generation of chipsets. I don't want to have to spend half of 2.7 decrufting agpgart again.

Dave

#2 lore raw
Quoted 7 lines · On Wed, 18 Feb 2004 20:23:25 +0000 Dave Jones <[email protected]> wrote:
Quoted 5 lines · Linux Kernel

ChangeSet 1.1564, 2004/02/18 11:44:38-08:00, [email protected]

[PATCH] Enable Intel AGP on x86-64

Enable the Intel AGP driver for x86-64 too.

Quoted 8 lines

Please don't do this. At least copy intel-agp.c to something new and throw out all the dozens of chipsets that will never appear on ia32e.

Splitting agpgart up to seperate drivers allowed us to stop adding cruft upon cruft with each generation of chipsets. I don't want to have to spend half of 2.7 decrufting agpgart again.

Huh? Did you actually read the patch? It doesn't change the AGP driver at all, just enables it in Kconfig because Intel chipsets can be now used on the x86-64 kernel too.

-Andi

author
#3 lore raw
Quoted 10 lines · Andi Kleen
Quoted 8 lines

Please don't do this. At least copy intel-agp.c to something new and throw out all the dozens of chipsets that will never appear on ia32e.

Splitting agpgart up to seperate drivers allowed us to stop adding cruft upon cruft with each generation of chipsets. I don't want to have to spend half of 2.7 decrufting agpgart again.

Huh? Did you actually read the patch?

Yes, did you actually read my mail?

Quoted 2 lines

It doesn't change the AGP driver at all, just enables it in Kconfig because Intel chipsets can be now used on the x86-64 kernel too.

You *really* think you're going to see a 440BX GART on ia32e ? i810 ? i820 ? i830 ? etc. etc. I'd be *very* surprised if anything but the current generation of ia32 chipsets gets used on ia32e. It just doesn't make sense.

Without even looking at the code I'll bet you can shrink it by at least 75%.

Dave

#4 lore raw
Quoted 6 lines · On Wed, 18 Feb 2004 20:44:06 +0000 Dave Jones <[email protected]> wrote:
Quoted 4 lines · Andi Kleen
Quoted 4 lines

Please don't do this. At least copy intel-agp.c to something new and throw out all the dozens of chipsets that will never appear on ia32e.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Splitting agpgart up to seperate drivers allowed us to stop adding cruft upon cruft with each generation of chipsets. I don't want to have to spend half of 2.7 decrufting agpgart again.

Huh? Did you actually read the patch?

Yes, did you actually read my mail?

I guess I had expected it to make more sense, but it didn't.

Quoted 11 lines
Quoted 3 lines

It doesn't change the AGP driver at all, just enables it in Kconfig because Intel chipsets can be now used on the x86-64 kernel too.

You *really* think you're going to see a 440BX GART on ia32e ? i810 ? i820 ? i830 ? etc. etc. I'd be *very* surprised if anything but the current generation of ia32 chipsets gets used on ia32e. It just doesn't make sense.

Without even looking at the code I'll bet you can shrink it by at least 75%.

Feel free to do that. I don't have any plans to hack the Intel AGP driver right now.

-Andi