Skip to contentSkip to conversation

patch to tftp.c

U-Boot-Users Josh Fryman 2 participants 2 messages Feb 21, 2004 – Feb 24, 2004

lore
Share & tools
lore
#0 lore raw

this patch for "tftp.c" fixes a logical error in the prior implementation supporting direct-tftp-to-flash. this puts in some additional safety checks to make sure you don't cross a flash boundary during the course of a write.

this will catch such actions before starting, and complain verbosely about what the actual problem is.

-josh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff.H
Type: application/octet-stream
Size: 2935 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040221/3c80d547/attachment.obj

#1 lore raw
Quoted 8 lines · In message <[email protected]> you wrote:

this patch for "tftp.c" fixes a logical error in the prior implementation supporting direct-tftp-to-flash. this puts in some additional safety checks to make sure you don't cross a flash boundary during the course of a write.

this will catch such actions before starting, and complain verbosely about what the actual problem is.

How can you know that in advance? There is no indication how big the file will become.

I don't really see which problem you are trying to fix (especially since downloading directlty to flash is inherently insecure and discouraged).

There is again no CHANGELOG entry.

Again there is violation of coding standards (trailing white space; brace style).

Rejected.

Best regards,

Wolfgang Denk

Signature · 5 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
What can it profit a man to gain the whole world and to come  to  his
property with a gastric ulcer, a blown prostate, and bifocals?
                                     -- John Steinbeck, _Cannery Row_