Skip to contentSkip to conversation

arch-specific callout in panic()

PATCH Arnd Bergmann 1 participant 1 message Feb 23, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 10 lines · Mike Strosaker
(quoted diff) +2 -1
@@ -53,7 +53,8 @@
       static char buf[1024];
       va_list args;
 #if defined(CONFIG_ARCH_S390)
-        unsigned long caller = (unsigned long) __builtin_return_address(0);
+       extern unsigned long panic_caller;
+        panic_caller = (unsigned long) __builtin_return_address(0);
 #endif
 
       bust_spinlocks(1);

...

Review

Quoted 2 lines
(quoted diff) +2 -0
+       machine_panic();
+

Why don't you just pass __builtin_return_address(0) to machine_panic for everyone? It will get you rid of the #ifdef completely and the argument can still be ignored.
Also, arch_panic() might be a little clearer than machine_panic().

	Arnd <><