Skip to contentSkip to conversation

i2c on alpha - used but not available in 2.6.3

DISCUSSION Jakub Bogusz 2 participants 6 messages Feb 25, 2004 – Feb 26, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Are i2c drivers valid on alpha?
They are not available because drivers/i2c/Kconfig (nor drivers/Kconfig which includes it) is not included from arch/alpha/Kconfig.

But many drivers making use of i2c can be enabled - and build with unresolved symbols (about 50 warnings - mostly in media/video drivers).

I checked that adding including of drivers/i2c/Kconfig to arch/alpha/Kconfig everything build and all remaining unresolved symbols fade away.

Signature · 2 lines
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Team        http://www.pld-linux.org/
#1 lore raw
Quoted 2 lines · Jakub Bogusz

I checked that adding including of drivers/i2c/Kconfig to arch/alpha/Kconfig everything build and all remaining unresolved symbols fade away.

I'd just switch alpha to use drivers/Kconfig

#2 lore raw
Quoted 5 lines · Christoph Hellwig
Quoted 2 lines · Jakub Bogusz

I checked that adding including of drivers/i2c/Kconfig to arch/alpha/Kconfig everything build and all remaining unresolved symbols fade away.

I'd just switch alpha to use drivers/Kconfig

Like in the attached patch?

I found few more differences:

- beside drivers/i2c there was no drivers/misc and drivers/telephony in alpha/Kconfig - was this intentional or accidental?

drivers/misc currently contains only IBM_ASM, which looks like some hardware-specific driver - maybe it should be available only on some arch(s)?

- on alpha drivers/parport was placed in "System setup" menu - but I suppose it can be moved to standard location without problems

- drivers/message/fusion was included only conditionaly, depending on PCI option (in drivers/Kconfig it's unconditional).
If message/fusion requires PCI, maybe it should have "depends on PCI" in its Kconfig?

Signature · 2 lines
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Team        http://www.pld-linux.org/
arch/alpha/Kconfig renamed from arch/alpha/Kconfig.orig +1 -40
@@ -596,51 +596,12 @@
 
 source "fs/Kconfig.binfmt"
 
-source "drivers/parport/Kconfig"
-
 endmenu
 
-source "drivers/base/Kconfig"
-
-source "drivers/mtd/Kconfig"
-
-source "drivers/pnp/Kconfig"
-
-source "drivers/block/Kconfig"
-
-source "drivers/md/Kconfig"
-
-source "drivers/ide/Kconfig"
-
-source "drivers/scsi/Kconfig"
-
-if PCI
-source "drivers/message/fusion/Kconfig"
-endif
-
-source "drivers/ieee1394/Kconfig"
-
-source "net/Kconfig"
-
-source "drivers/isdn/Kconfig"
-
-source "drivers/cdrom/Kconfig"
-
-source "drivers/input/Kconfig"
-
-source "drivers/char/Kconfig"
-
-#source drivers/misc/Config.in
-source "drivers/media/Kconfig"
+source "drivers/Kconfig"
 
 source "fs/Kconfig"
 
-source "drivers/video/Kconfig"
-
-source "sound/Kconfig"
-
-source "drivers/usb/Kconfig"
-
 source "arch/alpha/oprofile/Kconfig"
 
 menu "Kernel hacking"
#3 lore raw
Quoted 6 lines · Jakub Bogusz

- beside drivers/i2c there was no drivers/misc and drivers/telephony in alpha/Kconfig - was this intentional or accidental?

drivers/misc currently contains only IBM_ASM, which looks like some hardware-specific driver - maybe it should be available only on some arch(s)?

drivers/misc/ is empty here, and until we have some policy decision it should stay that way. What tree do you look at?

Quoted 2 lines

- on alpha drivers/parport was placed in "System setup" menu - but I suppose it can be moved to standard location without problems

Yes.

Quoted 4 lines

- drivers/message/fusion was included only conditionaly, depending on PCI option (in drivers/Kconfig it's unconditional).
If message/fusion requires PCI, maybe it should have "depends on PCI" in its Kconfig?

Yes, this is probably worth fixing.

#4 lore raw
Quoted 10 lines · Christoph Hellwig
Quoted 6 lines · Jakub Bogusz

- beside drivers/i2c there was no drivers/misc and drivers/telephony in alpha/Kconfig - was this intentional or accidental?

drivers/misc currently contains only IBM_ASM, which looks like some hardware-specific driver - maybe it should be available only on some arch(s)?

drivers/misc/ is empty here, and until we have some policy decision it should stay that way. What tree do you look at?

Uh, haven't noticed this comes from IBM-RAS patches in distribution tree. OK, so drivers/misc doesn't make any difference for now.

Quoted 11 lines
Quoted 2 lines

- on alpha drivers/parport was placed in "System setup" menu - but I suppose it can be moved to standard location without problems

Yes.

Quoted 4 lines

- drivers/message/fusion was included only conditionaly, depending on PCI option (in drivers/Kconfig it's unconditional).
If message/fusion requires PCI, maybe it should have "depends on PCI" in its Kconfig?

Yes, this is probably worth fixing.

OK, added the change to patch.

So is this patch correct now and would be accepted to Linux 2.6 tree?

Signature · 2 lines
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
PLD Team        http://www.pld-linux.org/
arch/alpha/Kconfig renamed from arch/alpha/Kconfig.orig +1 -40
@@ -596,51 +596,12 @@
 
 source "fs/Kconfig.binfmt"
 
-source "drivers/parport/Kconfig"
-
 endmenu
 
-source "drivers/base/Kconfig"
-
-source "drivers/mtd/Kconfig"
-
-source "drivers/pnp/Kconfig"
-
-source "drivers/block/Kconfig"
-
-source "drivers/md/Kconfig"
-
-source "drivers/ide/Kconfig"
-
-source "drivers/scsi/Kconfig"
-
-if PCI
-source "drivers/message/fusion/Kconfig"
-endif
-
-source "drivers/ieee1394/Kconfig"
-
-source "net/Kconfig"
-
-source "drivers/isdn/Kconfig"
-
-source "drivers/cdrom/Kconfig"
-
-source "drivers/input/Kconfig"
-
-source "drivers/char/Kconfig"
-
-#source drivers/misc/Config.in
-source "drivers/media/Kconfig"
+source "drivers/Kconfig"
 
 source "fs/Kconfig"
 
-source "drivers/video/Kconfig"
-
-source "sound/Kconfig"
-
-source "drivers/usb/Kconfig"
-
 source "arch/alpha/oprofile/Kconfig"
 
 menu "Kernel hacking"
drivers/message/fusion/Kconfig renamed from drivers/message/fusion/Kconfig.orig +1 -1
@@ -3,7 +3,7 @@
 
 config FUSION
 	tristate "Fusion MPT (base + ScsiHost) drivers"
-	depends on BLK_DEV_SD
+	depends on BLK_DEV_SD && PCI
 	---help---
 	  LSI Logic Fusion(TM) Message Passing Technology (MPT) device support
 	  provides high performance SCSI host initiator, and LAN [1] interface
#5 lore raw
Quoted 3 lines · Jakub Bogusz

OK, added the change to patch.

So is this patch correct now and would be accepted to Linux 2.6 tree?

fine with me. Ping akpm and linus for it.