vicam ioctl VIDIOCSWIN wrong return value

PATCH New Frank Cusack 1 participant 1 message Mar 1, 2004 USB

lore

Share & tools

lore

Frank Cusack

author

2004-03-01 22:50 UTC #0 lore raw

PATCH 1/1 vicam ioctl VIDIOCSWIN wrong return value

Should this return -EINVAL? (credit to Paul Menage).

drivers/usb/vicam.c +1 -1

diff -urp linux-2.4.25/drivers/usb/vicam.c linux-2.4.25.1/drivers/usb/vicam.c
@@ -612,7 +612,7 @@ vicam_ioctl(struct video_device *dev, un
 			DBG("VIDIOCSWIN %d x %d\n", vw->width, vw->height);
 			
 			if ( vw.width != 320 || vw.height != 240 )
-				retval = -EFAULT;
+				retval = -EINVAL;
 
 			break;
 		}

/fc