Skip to contentSkip to conversation

ia32 sigwait patch

DISCUSSION Bjorn Helgaas 2 participants 2 messages Mar 3, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · you

ia32 rt_sigtimewait() fails when some of the arguments are NULL. The fix is attached.

Sorry for the delay in responding; I've been out of the office for a while. I applied the patch (with the addition of a few spaces in the ternary operator).

It looks to me like current 2.4 on x86_64 suffers from the same problem with uts (sys_rt_sigtimedwait() gets a pointer to uninitialized "t" when uts is NULL).

arch/ia64/ia32/ia32_signal.c renamed from arch/ia64/ia32/ia32_signal.c.ori +1 -1
@@ -614,7 +614,7 @@
 			return -EFAULT;
 	}
 	set_fs(KERNEL_DS);
-	ret = sys_rt_sigtimedwait(&s, &info, &t, sigsetsize);
+	ret = sys_rt_sigtimedwait(&s, uinfo? &info :NULL, uts? &t :NULL, sigsetsize);
 	set_fs(old_fs);
 	if (ret >= 0 && uinfo) {
 		if (copy_siginfo_to_user32(uinfo, &info))
#1 lore raw
Quoted 3 lines · On Wed, 3 Mar 2004 16:06:16 -0700 Bjorn Helgaas <[email protected]> wrote:

It looks to me like current 2.4 on x86_64 suffers from the same problem with uts (sys_rt_sigtimedwait() gets a pointer to uninitialized "t" when uts is NULL).

Yes, indeed. Thanks for the hint.

-Andi