Skip to contentSkip to conversation

vmalloc fix buggy again?

DISCUSSION Sergey Vlasov 2 participants 2 messages Mar 18, 2004

lore
Share & tools
lore
#0 lore raw

Hello!

Quoted 8 lines

# ChangeSet
# 2004/03/14 13:16:58-03:00 mlord...
# [PATCH] Yet another vmalloc() fixup
#
diff -Nru a/mm/vmalloc.c b/mm/vmalloc.c

mm/vmalloc.c line 190

Quoted 8 lines
mm/vmalloc.c +1 -1
@@ -184,7 +184,7 @@
 	spin_unlock(&init_mm.page_table_lock);
 	flush_cache_all();
 	if (address > start)
-		vmfree_area_pages((address - start), address - start);
+		vmfree_area_pages(address, address - start);
 	return -ENOMEM;
 }
 

Looks like this should be

		vmfree_area_pages(start, address - start);
Signature · 1 line
Sergey Vlasov
#1 lore raw

Yup.

Thanks, Sergey. I'm suffering severe brain-impairment on this one. Please pass this on to Marcelo.

Cheers

Signature · 3 lines
Mark Lord
Real-Time Remedies Inc.
[email protected]
Quoted 24 lines · Sergey Vlasov

Hello!

Quoted 7 lines

# ChangeSet
# 2004/03/14 13:16:58-03:00 mlord...
# [PATCH] Yet another vmalloc() fixup

# diff -Nru a/mm/vmalloc.c b/mm/vmalloc.c

mm/vmalloc.c line 190

Quoted 8 lines
mm/vmalloc.c +1 -1
@@ -184,7 +184,7 @@
 	spin_unlock(&init_mm.page_table_lock);
 	flush_cache_all();
 	if (address > start)
-		vmfree_area_pages((address - start), address - start);
+		vmfree_area_pages(address, address - start);
 	return -ENOMEM;
 }
 

Looks like this should be

		vmfree_area_pages(start, address - start);