Skip to contentSkip to conversation

ISDN Eicon driver: restructured capi list and lock handling

PATCH Arjan van de Ven 2 participants 3 messages Mar 22, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 7 lines · Linux Kernel Mailing List

ChangeSet 1.1828, 2004/03/21 08:55:24-08:00, [email protected]

[PATCH] ISDN Eicon driver: restructured capi list and lock handling

Restructered the CAPI code of list handling and lock.

Removed obsolete code.

this patch is broken:
Error: ./drivers/isdn/hardware/eicon/capifunc.o .altinstructions refers
to 00000018 R_386_32 .exit.text
Error: ./drivers/isdn/hardware/eicon/capifunc.o .init.text refers to
0000015d R_386_PC32 .exit.text

eg you call __exit functions from __init functions, which is incorrect....

#2 lore raw
Quoted 9 lines · Arjan van de Ven
Quoted 7 lines · Linux Kernel Mailing List

ChangeSet 1.1828, 2004/03/21 08:55:24-08:00, [email protected]

[PATCH] ISDN Eicon driver: restructured capi list and lock handling

Restructered the CAPI code of list handling and lock.

Removed obsolete code.

Quoted 8 lines

this patch is broken:
Error: ./drivers/isdn/hardware/eicon/capifunc.o .altinstructions refers
to 00000018 R_386_32 .exit.text
Error: ./drivers/isdn/hardware/eicon/capifunc.o .init.text refers to
0000015d R_386_PC32 .exit.text

eg you call __exit functions from __init functions, which is incorrect....

and the fix:

drivers/isdn/hardware/eicon/capifunc.c renamed from drivers/isdn/hardware/eicon/capifunc.c~ +1 -1
@@ -455,7 +455,7 @@
 /*
  * remove cards
  */
-static void DIVA_EXIT_FUNCTION divacapi_remove_cards(void)
+static void divacapi_remove_cards(void)
 {
 	DESCRIPTOR d;
 	struct list_head *tmp;
#3 lore raw
Quoted 26 lines · Arjan van de Ven
Quoted 9 lines · Arjan van de Ven
Quoted 7 lines · Linux Kernel Mailing List

ChangeSet 1.1828, 2004/03/21 08:55:24-08:00, [email protected]

[PATCH] ISDN Eicon driver: restructured capi list and lock handling

Restructered the CAPI code of list handling and lock.

Removed obsolete code.

Quoted 8 lines

this patch is broken:
Error: ./drivers/isdn/hardware/eicon/capifunc.o .altinstructions refers
to 00000018 R_386_32 .exit.text
Error: ./drivers/isdn/hardware/eicon/capifunc.o .init.text refers to
0000015d R_386_PC32 .exit.text

eg you call __exit functions from __init functions, which is incorrect....

and the fix:

drivers/isdn/hardware/eicon/capifunc.c line 461

Quoted 8 lines
drivers/isdn/hardware/eicon/capifunc.c renamed from drivers/isdn/hardware/eicon/capifunc.c~ +1 -1
@@ -455,7 +455,7 @@
 /*
  * remove cards
  */
-static void DIVA_EXIT_FUNCTION divacapi_remove_cards(void)
+static void divacapi_remove_cards(void)
 {
 	DESCRIPTOR d;
 	struct list_head *tmp;

Yes, you are correct. I wonder why my compiler didn't complain about this. It works here and I don't know why. What configuration did you use?

I will create a correct incremental patch (another patch for this file is already send to Linus) for Linus/Andrew.

Thanks for pointing out.

Armin