NCR53C9x unused SCp.have_data_in
PATCH 1/1 NCR53C9x unused SCp.have_data_in
NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W. Rozycki). This affects the following drivers:
- Amiga Oktagon SCSI
- DECstation SCSI
The change for DECstation SCSI sneaked in through a MIPS update.
drivers/scsi/NCR53C9x.c +1 -1
@@ -917,7 +917,7 @@if (esp->dma_mmu_get_scsi_one) esp->dma_mmu_get_scsi_one (esp, sp);else - sp->SCp.have_data_in = (int ) sp->SCp.ptr = + sp->SCp.ptr = (char *)virt_to_phys (sp->request_buffer); }else { sp->SCp.buffer = (struct scatterlist *) sp->buffer;
drivers/scsi/oktagon_esp.c +1 -1
@@ -548,7 +548,7 @@void dma_mmu_get_scsi_one (struct NCR_ESP *esp,Scsi_Cmnd *sp) { - sp->SCp.have_data_in = (int ) sp->SCp.ptr = + sp->SCp.ptr = sp->request_buffer; }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 21 lines · Geert Uytterhoeven
NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W. Rozycki). This affects the following drivers:
- Amiga Oktagon SCSI
- DECstation SCSIThe change for DECstation SCSI sneaked in through a MIPS update.
drivers/scsi/NCR53C9x.c +1
-1@@ -917,7 +917,7 @@if (esp->dma_mmu_get_scsi_one) esp->dma_mmu_get_scsi_one (esp, sp);else - sp->SCp.have_data_in = (int ) sp->SCp.ptr = + sp->SCp.ptr = (char *)virt_to_phys (sp->request_buffer); }else { sp->SCp.buffer = (struct scatterlist *) sp->buffer;
drivers/scsi/oktagon_esp.c line 553
Quoted 7 lines
drivers/scsi/oktagon_esp.c +1
-1@@ -548,7 +548,7 @@void dma_mmu_get_scsi_one (struct NCR_ESP *esp,Scsi_Cmnd *sp) { - sp->SCp.have_data_in = (int ) sp->SCp.ptr = + sp->SCp.ptr = sp->request_buffer; }
Can't we live with this?
Is removing it fixing any problem?
Yes, I'm being picky.
Quoted 23 lines · Marcelo Tosatti
Quoted 22 lines · Geert Uytterhoeven
NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W. Rozycki). This affects the following drivers:
- Amiga Oktagon SCSI
- DECstation SCSIThe change for DECstation SCSI sneaked in through a MIPS update.
drivers/scsi/NCR53C9x.c +1
-1@@ -917,7 +917,7 @@if (esp->dma_mmu_get_scsi_one) esp->dma_mmu_get_scsi_one (esp, sp);else - sp->SCp.have_data_in = (int ) sp->SCp.ptr = + sp->SCp.ptr = (char *)virt_to_phys (sp->request_buffer); }else { sp->SCp.buffer = (struct scatterlist *) sp->buffer;drivers/scsi/oktagon_esp.c +0
-0@@ -548,7 +548,7 @@
Quoted 8 lines
drivers/scsi/oktagon_esp.c line 553
Quoted 6 lines
drivers/scsi/oktagon_esp.c +1
-1void dma_mmu_get_scsi_one (struct NCR_ESP *esp,Scsi_Cmnd *sp) { - sp->SCp.have_data_in = (int ) sp->SCp.ptr = + sp->SCp.ptr = sp->request_buffer; }Can't we live with this?
Yes.
Quoted 1 line
Is removing it fixing any problem?
No, it's just a cleanup.
Quoted 1 line
Yes, I'm being picky.
In that case, you can drop it.
(BTW, picky for 2.4.26-rc*, or for 2.4 in general?)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 37 lines · Geert Uytterhoeven
Quoted 23 lines · Marcelo Tosatti
Quoted 22 lines · Geert Uytterhoeven
NCR53C9x: Remove unused initialization of SCp.have_data_in (from Maciej W. Rozycki). This affects the following drivers:
- Amiga Oktagon SCSI
- DECstation SCSIThe change for DECstation SCSI sneaked in through a MIPS update.
drivers/scsi/NCR53C9x.c +1
-1@@ -917,7 +917,7 @@if (esp->dma_mmu_get_scsi_one) esp->dma_mmu_get_scsi_one (esp, sp);else - sp->SCp.have_data_in = (int ) sp->SCp.ptr = + sp->SCp.ptr = (char *)virt_to_phys (sp->request_buffer); }else { sp->SCp.buffer = (struct scatterlist *) sp->buffer;drivers/scsi/oktagon_esp.c +0
-0@@ -548,7 +548,7 @@Quoted 8 lines
drivers/scsi/oktagon_esp.c line 553
Quoted 6 lines
drivers/scsi/oktagon_esp.c +1
-1void dma_mmu_get_scsi_one (struct NCR_ESP *esp,Scsi_Cmnd *sp) { - sp->SCp.have_data_in = (int ) sp->SCp.ptr = + sp->SCp.ptr = sp->request_buffer; }Can't we live with this?
Yes.
Quoted 1 line
Is removing it fixing any problem?
Quoted 7 lines
No, it's just a cleanup.
Quoted 1 line
Yes, I'm being picky.
In that case, you can drop it.
(BTW, picky for 2.4.26-rc*, or for 2.4 in general?)
Picky in general for 2.4. In this case specifically I feel the cleanup can possibly, "remotely" cause some issues. Better to be off.