ATOMIC_HASH brainfart
Hi all,
Seems like someone was confused when they hacked ATOMIC_HASH macro. Cacheline is 64 bytes not 256...but I've been told several times gcc is smart enough to convert "foo/64" to "foo>>6"...then just use the L1_CACHE_BYTES definition to indicate intent?
I haven't verified everything builds and works right but it looks "obviously correct" to me. Comments?
I'm still looking at getting SMP to boot.
grant
Index: include/asm/atomic.h
===================================================================
RCS file: /var/cvs/linux-2.6/include/asm-parisc/atomic.h,v retrieving revision 1.6
include/asm/atomic.h +2 -2
@@ -19,10 +19,10 @@ typedef spinlock_t atomic_lock_t;/* Use an array of spinlocks for our atomic_ts. * Hash function to index into a different SPINLOCK. -* Since "a" is usually an address, ">>8" makes one spinlock per 64-bytes. +* Since "a" is usually an address, use one spinlock per cacheline. */ # define ATOMIC_HASH_SIZE 4 -# define ATOMIC_HASH (a) (&__atomic_hash[(((unsigned long) a)>>8)&(ATOMIC_HASH_SIZE-1)]) +# define ATOMIC_HASH (a) (&__atomic_hash[(((unsigned long) a)/L1_CACHE_BYTES)&(ATOMIC_HASH_SIZE-1)]) extern atomic_lock_t __atomic_hash[ATOMIC_HASH_SIZE] __lock_aligned;
Quoted 5 lines · Grant Grundler
Hi all,
Seems like someone was confused when they hackedATOMIC_HASHmacro. Cacheline is 64 bytes not 256...but I've been told several times gcc is smart enough to convert "foo/64" to "foo>>6"...then just use theL1_CACHE_BYTESdefinition to indicate intent?
IFF foo is a constant or foo is unsigned. Looks fine to me
Quoted 6 lines
Quoted 4 lines
Seems like someone was confused when they hacked
ATOMIC_HASHmacro. Cacheline is 64 bytes not 256...but I've been told several times gcc is smart enough to convert "foo/64" to "foo>>6"...then just use theL1_CACHE_BYTESdefinition to indicate intent?IFF foo is a constant or foo is unsigned. Looks fine to me
or you can even use L1_CACHE_SHIFT :)
randolph
Signature · 3 lines
Randolph Chung Debian GNU/Linux Developer, hppa/ia64 ports http://www.tausq.org/