Skip to contentSkip to conversation

fix load_elf_binary error path on unshare_files error

PATCH New Chris Wright 1 participant 1 message Apr 8, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix load_elf_binary error path on unshare_files error

Make sure to return proper retval on unshare_files() error in load_elf_binary. Patch against 2.4.26-rc2.

Error noted by Kirill Korotaev <[email protected]>.

===== fs/binfmt_elf.c 1.28 vs edited =====

fs/binfmt_elf.c +2 -1
@@ -479,7 +479,8 @@
 		goto out_free_ph;
 		
 	files = current->files;		/* Refcounted so ok */
-	if(unshare_files() < 0)
+	retval = unshare_files();
+	if (retval < 0)
 		goto out_free_ph;
 	if (files == current->files) {
 		put_files_struct(files);