Skip to contentSkip to conversation

drivers/char/KConfig: Remove "BROKEN_ON_SMP" tag on CYCLADES entry

PATCH New Marcelo Tosatti 1 participant 1 message Apr 9, 2004 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/char/KConfig: Remove "BROKEN_ON_SMP" tag on CYCLADES entry

Hi Andrew,

The cyclades.c driver was marked BROKEN_ON_SMP during early 2.6. It was fixed later on but the tag was left in Kconfig.

The driver is not very smart wrt SMP locking, it can be improved. There is only one spinlock percard which guarantees command block ordering and protects different shared data, which can be held for long periods.

_But_ the locking works reliably, so remove the BROKEN_ON_SMP tag.

Please apply.

drivers/char/Kconfig +1 -1
@@ -110,7 +110,7 @@
 
 config CYCLADES
 	tristate "Cyclades async mux support"
-	depends on SERIAL_NONSTANDARD && BROKEN_ON_SMP
+	depends on SERIAL_NONSTANDARD
 	---help---
 	  This is a driver for a card that gives you many serial ports. You
 	  would need something like this to connect more than two modems to