Skip to contentSkip to conversation

USB usbfs: drop pointless racy check

PATCH In review Duncan Sands 1 participant 1 message Apr 14, 2004 USB

lore
Share & tools
lore
#0 lore raw

PATCH 9/9 USB usbfs: drop pointless racy check

The check of interface->dev.driver requires a lock to be taken to protect against driver binding changes. But in fact I think it is better just to drop the test. The result is that the caller is required to claim an interface before changing the altsetting, which is consistent with the other routines that operate on interfaces.

 devio.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
drivers/usb/core/devio.c +2 -4
diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
@@ -747,10 +747,8 @@
 	if ((ret = findintfif(ps->dev, setintf.interface)) < 0)
 		return ret;
 	interface = ps->dev->actconfig->interface[ret];
-	if (interface->dev.driver) {
-		if ((ret = checkintf(ps, ret)))
-			return ret;
-	}
+	if ((ret = checkintf(ps, ret)))
+		return ret;
 	if (usb_set_interface(ps->dev, setintf.interface, setintf.altsetting))
 		return -EINVAL;
 	return 0;