yam driver null deref
drivers/net/hamradio/yam.c renamed from drivers/net/hamradio/yam.c~ +5 -2
@@ -919,9 +919,12 @@static int yam_close (struct net_device *dev) {struct sk_buff *skb; -struct yam_port *yp = (struct yam_port *) dev->priv; +struct yam_port *yp; -if (!dev || !yp) +if (!dev) +return -EINVAL ; + yp = dev->priv; +if (!yp)return -EINVAL ;/* * disable interrupts
Quoted 5 lines · Dave Jones
drivers/net/hamradio/yam.c renamed from drivers/net/hamradio/yam.c~ +0
-0@@ -919,9 +919,12 @@static int yam_close (struct net_device *dev) {
drivers/net/hamradio/yam.c line 928
Quoted 10 lines
drivers/net/hamradio/yam.c renamed from drivers/net/hamradio/yam.c~ +5
-2struct sk_buff *skb; -struct yam_port *yp = (struct yam_port *) dev->priv; +struct yam_port *yp; -if (!dev || !yp) +if (!dev) +return -EINVAL ; + yp = dev->priv; +if (!yp)return -EINVAL ;
Ditto... dev will never be NULL here. And most likely not dev->priv either.
Jeff