flashh
PATCH 1/1 flashh
ChangeLog:
* Patch by Kai-Uwe Bloem, Robert Schwebel, 13 May 2004:
Add support for Intel K3 strata flashs.
Robert
Signature · 42 lines
Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
Handelsregister: Amtsgericht Hildesheim, HRA 2686
Hornemannstra?e 12, 31137 Hildesheim, Germany
Phone: +49-5121-28619-0 | Fax: +49-5121-28619-4
-------------- next part --------------
#
# Author: Robert Schwebel <[email protected]>
#
# Description: Changelog Entry:
#
# * Patch by Kai-Uwe Bloem, Robert Schwebel, 13 May 2004:
# Add support for Intel K3 strata flashs.
#
# State: 2004-05-13: submit
#
#
# Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
#
--- u-boot-ptx-test/include/flash.h~flashh 2004-02-10 12:44:30.000000000 +0100
+++ u-boot-ptx-test/include/flash.h 2004-02-10 13:03:21.000000000 +0100
@@ -231,6 +231,9 @@
#define INTEL_ID_28F160S3 0x00D000D0 /* 16M = 512K x 32 (64kB x 32) */
#define INTEL_ID_28F320S3 0x00D400D4 /* 32M = 512K x 64 (64kB x 64) */
+#define INTEL_ID_28F128K3 0x88028802 /* 128M = 128K x 128 */
+#define INTEL_ID_28F256K3 0x88038803 /* 256M = 128K x 256 */
+
/* Note that the Sharp 28F016SC is compatible with the Intel E28F016SC */
#define SHARP_ID_28F016SCL 0xAAAAAAAA /* LH28F016SCT-L95 2Mx8, 32 64k blocks */
#define SHARP_ID_28F016SCZ 0xA0A0A0A0 /* LH28F016SCT-Z4 2Mx8, 32 64k blocks */
@@ -340,6 +343,9 @@
#define FLASH_AMDL163T 0x00B2 /* AMD AM29DL163T (2M x 16 ) */
#define FLASH_AMDL163B 0x00B3
+#define FLASH_28F128K3 0x00A7 /* Intel 28F128K3 ( 128M = 8M x 16 ) */
+#define FLASH_28F256K3 0x00A8 /* Intel 28F256K3 ( 256M = 16M x 16 ) */
+
#define FLASH_UNKNOWN 0xFFFF /* unknown flash type */PATCH 1/1 flashh
Dear Robert,
Quoted 3 lines · in message <[email protected]> you wrote:
* Patch by Kai-Uwe Bloem, Robert Schwebel, 13 May 2004:
Add support for Intel K3 strata flashs.
Parts of this patch have been obsolteted by recent additions, other parts are IMHO wrong:
include/flash.h line 236
Quoted 9 lines
include/flash.h renamed from include/flash.h~flashh +3
-0@@ -231,6 +231,9 @@#define INTEL_ID_28F160S3 0x00D000D0/* 16M = 512K x 32 (64kB x 32) */ #define INTEL_ID_28F320S3 0x00D400D4/* 32M = 512K x 64 (64kB x 64) */ +#define INTEL_ID_28F128K3 0x88028802/* 128M = 128K x 128 */ +#define INTEL_ID_28F256K3 0x88038803/* 256M = 128K x 256 */ +
Already included now.
include/flash.h line 346
Quoted 8 lines
include/flash.h renamed from include/flash.h~flashh +1
-0/* Note that the Sharp 28F016SC is compatible with the Intel E28F016SC */ #define SHARP_ID_28F016SCL 0xAAAAAAAA/* LH28F016SCT-L95 2Mx8, 32 64k blocks */ #define SHARP_ID_28F016SCZ 0xA0A0A0A0/* LH28F016SCT-Z4 2Mx8, 32 64k blocks */ @@ -340,6 +343,9 @@#define FLASH_AMDL163T 0x00B2/* AMD AM29DL163T (2M x 16 ) */ #define FLASH_AMDL163B 0x00B3 +#define FLASH_28F128K3 0x00A7/* Intel 28F128K3 ( 128M = 8M x 16 ) */
This is IMHO wrong. The comment a few lines above reads:
Be careful when adding new type! Odd numbers are "bottom boot sector" types!
I don't think this is a bottom boot sector type.
include/flash.h line 348
Quoted 2 lines
include/flash.h renamed from include/flash.h~flashh +2
-0+#define FLASH_28F256K3 0x00A8/* Intel 28F256K3 ( 256M = 16M x 16 ) */ +
Already included now.
Please fix and resubmit if needed.
Best regards,
Wolfgang Denk
Signature · 6 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de I distrust all systematisers, and avoid them. The will to a system shows a lack of honesty. - Friedrich Wilhelm Nietzsche _G?tzen-D?mmerung [The Twilight of the Idols]_ ``Maxims and Missiles'' no. 26
PATCH 1/1 flashh
In reply to a message not in the archiveQuoted 11 lines · Wolfgang Denk
Review line 346
Quoted 5 lines
(quoted diff) +1
-0@@ -340,6 +343,9 @@ #define FLASH_AMDL163T 0x00B2 /* AMD AM29DL163T (2M x 16 ) */ #define FLASH_AMDL163B 0x00B3 +#define FLASH_28F128K3 0x00A7 /* Intel 28F128K3 ( 128M = 8M x 16 ) */This is IMHO wrong. The comment a few lines above reads:
Be careful when adding new type! Odd numbers are "bottom boot sector" types!
I don't think this is a bottom boot sector type.
It's a "all sectors are created equal" type ;)
Quoted 6 lines
Review line 348
Quoted 2 lines
(quoted diff) +2
-0+#define FLASH_28F256K3 0x00A8 /* Intel 28F256K3 ( 256M = 16M x 16 ) */ +Already included now.
Please fix and resubmit if needed.
I'm a little bit confused; I understand these numbers as internal U-Boot identifiers, arent' they? The list has duplicate entries. And, according to what you said above, how is this meant:
#define FLASH_28F320J3A 0x007C /* INTEL 28F320J3A ( 32M = 128K x 32) */ #define FLASH_28F640J3A 0x007D /* INTEL 28F640J3A ( 64M = 128K x 64) */ #define FLASH_28F128J3A 0x007E /* INTEL 28F128J3A (128M = 128K x 128) */
These are equal sized as well but have ascending numbers. New patch is attached.
Robert
Signature · 43 lines
Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
Handelsregister: Amtsgericht Hildesheim, HRA 2686
Hornemannstra?e 12, 31137 Hildesheim, Germany
Phone: +49-5121-28619-0 | Fax: +49-5121-28619-4
-------------- next part --------------
#
# Author: Robert Schwebel <[email protected]>
#
# Description: Changelog Entry:
#
# * Patch by Kai-Uwe Bloem, Robert Schwebel, 13 May 2004:
# Add support for Intel K3 strata flashs.
#
# State: 2004-05-13: submitted
#
# 2004-06-10: INTEL_IDs added. WD: internal IDs have to be
# even for non-bottom type flashes.
#
# 2004-06-10: submitted
#
#
# Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
#
--- u-boot-maintainance/include/flash.h 2004-06-10 12:59:28.000000000 +0200
+++ u-boot-maintainance-ptx/include/flash.h 2004-06-10 16:21:09.000000000 +0200
@@ -364,11 +364,11 @@
#define FLASH_AMLV256U 0x00AA /* AMD 29LV256M ( 256M = 16M x 16 ) */
#define FLASH_MXLV320B 0x00AB /* MX 29LV320MB ( 32M = 2M x 16 ) */
#define FLASH_MXLV320T 0x00AC /* MX 29LV320MT ( 32M = 2M x 16 ) */
-/* Intel 28F256L18T 256M = 128K x 255 + 32k x 4 */
-#define FLASH_28F256L18T 0x00B0
-#define FLASH_28F256K3 0x00A8
+#define FLASH_28F256L18T 0x00B0 /* Intel 28F256L18T 256M = 128K x 255 + 32k x 4 */
#define FLASH_AMDL163T 0x00B2 /* AMD AM29DL163T (2M x 16 ) */
#define FLASH_AMDL163B 0x00B3
+#define FLASH_28F128K3 0x00B6 /* Intel 28F128K3 ( 128M = 8M x 16 ) */
+#define FLASH_28F256K3 0x00B8 /* Intel 28F256K3 ( 256M = 16M x 16 ) */
#define FLASH_FUJLV650 0x00B4 /* Fujitsu MBM 29LV650UE/651UE */PATCH 1/1 flashh
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 6 lines
Quoted 2 lines
+#define
FLASH_28F128K30x00A7/* Intel 28F128K3 ( 128M = 8M x 16 ) */This is IMHO wrong. The comment a few lines above reads:
Be careful when adding new type! Odd numbers are "bottom boot sector" types!
I don't think this is a bottom boot sector type.It's a "all sectors are created equal" type ;)
That's what I thought, too. So it must have an even ID.
Quoted 2 lines
I'm a little bit confused; I understand these numbers as internal U-Boot identifiers, arent' they? The list has duplicate entries. And, according
Yes, they are internal IDs only, but I try to enforce some rules.
Quoted 8 lines
to what you said above, how is this meant:
#define FLASH_28F320J3A 0x007C /* INTEL 28F320J3A ( 32M = 128K x 32) */ #define FLASH_28F640J3A 0x007D /* INTEL 28F640J3A ( 64M = 128K x 64) */ #define FLASH_28F128J3A 0x007E /* INTEL 28F128J3A (128M = 128K x 128) */These are equal sized as well but have ascending numbers. New patch is attached.
Nice catch. This escaped me when it was added - I'm far from being perfect. Fixed.
Best regards,
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de "355/113 -- Not the famous irrational number PI, but an incredible simulation!"