ia64 cpu hotplug patch
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): 20040515191217.GB24541@krispykreme
A message that is not in the archive (sent off-list or not yet received): 1084867279.20916.61.camel@bach
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): 20040518181214.GR2151@krispykreme
Quoted 6 lines · Anton Blanchard
Quoted 3 lines
Gack, Rusty, I wish you had less SMTP latency. I'm not sure what this is about. If it pertains to some patch which I'm carrying, someone tell me what one ;)
One of the ia64 hotplug patches that got merged. It seems they got itchy fingers and changed a few more things than they should have.
Precisely. This applies against Linus' kernel:
Name: Fix overzealous use of online cpu iterators
Status: Trivial
The IA64 hotplug CPU merge seems to have included some core changes: in particular the recalc_bh_state() needs to sum for all (including offline) cpus, since we don't empty the counters on CPU down. I don't know that anyone cares about the accuracy of the /proc/stat when CPUs go down, but certainly the totals printed (the first loop) should include offline cpus.
fs/buffer.c +1 -1
@@ -3019,7 +2966,7 @@if (__get_cpu_var (bh_accounting).ratelimit++ <4096 )return ;__get_cpu_var (bh_accounting).ratelimit =0 ; -for_each_online_cpu (i) +for_each_cpu (i) tot +=per_cpu (bh_accounting, i).nr; buffer_heads_over_limit = (tot > max_buffer_heads); }
fs/proc/proc_misc.c +2 -2
@@ -368,7 +368,7 @@if (wall_to_monotonic.tv_nsec) --jif; -for_each_online_cpu (i) { +for_each_cpu (i) {int j; user +=kstat_cpu (i).cpustat.user;
@@ -390,7 +390,7 @@ (unsigned long long )jiffies_64_to_clock_t (iowait), (unsigned long long )jiffies_64_to_clock_t (irq), (unsigned long long)jiffies_64_to_clock_t(softirq)); -for_each_online_cpu (i) { +for_each_cpu (i) {/* Copy values here to work around gcc-2.95.3, gcc-2.96 */ user =kstat_cpu (i).cpustat.user;
Signature · 1 line
Anyone who quotes me in their signature is an idiot -- Rusty Russell
Quoted 16 lines · Rusty Russell
Quoted 2 lines · Anton Blanchard
Quoted 2 lines
Gack, Rusty, I wish you had less SMTP latency. I'm not sure what
this is about. If it pertains to some patch which I'm carrying,someone
Quoted 3 lines
Quoted 1 line
tell me what one ;)
One of the ia64 hotplug patches that got merged. It seems they got
itchy
Quoted 1 line
fingers and changed a few more things than they should have.
Precisely. This applies against Linus' kernel:
Name: Fix overzealous use of online cpu iterators
Status: Trivial
Quoted 8 lines
The IA64 hotplug CPU merge seems to have included some core changes:
in
particular therecalc_bh_state()needs to sum for all (including offline) cpus, since we don't empty the counters on CPU down. I don't know that anyone cares about the accuracy of the/proc/statwhen CPUs go
down, but certainly the totals printed (the first loop) should include offline cpus.
Sorry... my mistake!
proc_misc.c was changed, since top() uses this to read and display stats. With cpuhotplug cpu_possible() represents the entire set of NR_CPUS, all these stats with 0 values and top gets all dorky about it.
Maybe the right thing would be to fix the utility instead ?
Other issue i noticied was that when we have a 4 cpu system, and you remove an intermediate cpu say cpu2, top utility is dorky again. And prints "invalid data" in the middle of the output.
Without the fix to proc_misc, if NR_CPUS is set to 128, top lists all 128 cpu stats even if only 4 are present and online, since for_each_cpu reprensents all of it....
Quoted 37 lines
--- b/fs/proc/proc_misc.c Fri May 14 23:11:58 2004 +++ a/fs/proc/proc_misc.c Tue Mar 23 02:05:27 2004 @@ -368,7 +368,7 @@ if (wall_to_monotonic.tv_nsec) --jif; - for_each_online_cpu(i) { + for_each_cpu(i) { int j; user += kstat_cpu(i).cpustat.user; @@ -390,7 +390,7 @@ (unsigned long long)jiffies_64_to_clock_t(iowait), (unsigned long long)jiffies_64_to_clock_t(irq), (unsigned long long)jiffies_64_to_clock_t(softirq)); - for_each_online_cpu(i) { + for_each_cpu(i) { /* Copy values here to work around gcc-2.95.3, gcc-2.96 */ user = kstat_cpu(i).cpustat.user; -- Anyone who quotes me in their signature is an idiot -- Rusty Russell - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at [1]http://vger.kernel.org/majordomo-info.html Please read the FAQ at [2]http://www.tux.org/lkml/References
1. http://vger.kernel.org/majordomo-info.html
2. http://www.tux.org/lkml/
Quoted 7 lines · Ashok Raj
proc_misc.cwas changed, sincetop()uses this to read and display stats. With cpuhotplugcpu_possible()represents the entire set ofNR_CPUS, all these stats with 0 values and top gets all dorky about it.Maybe the right thing would be to fix the utility instead ?
Quoted 7 lines
Other issue i noticied was that when we have a 4 cpu system, and you remove an intermediate cpu say cpu2, top utility is dorky again. And prints "invalid data" in the middle of the output.
Without the fix to
proc_misc, ifNR_CPUSis set to 128, top lists all 128 cpu stats even if only 4 are present and online, sincefor_each_cpureprensents all of it....
OK, well if you're correlating /proc/cpuinfo (online cpus) and /proc/stat (possible cpus), then I can understand top getting upset.
Perhaps we should only show online cpus in /proc/stat, but the totals displayed must still include all CPUs I think.
How's this version:
Name: Fix overzealous use of online cpu iterators
Status: Trivial
The IA64 hotplug CPU merge seems to have included some core changes: in particular the recalc_bh_state() needs to sum for all (including offline) cpus, since we don't empty the counters on CPU down. The totals printed by /proc/stat (the first loop) should include offline cpus, too (apparently printing out the per-cpu lines for offline cpus confuses top).
fs/buffer.c +1 -1
@@ -3019,7 +2966,7 @@if (__get_cpu_var (bh_accounting).ratelimit++ <4096 )return ;__get_cpu_var (bh_accounting).ratelimit =0 ; -for_each_online_cpu (i) +for_each_cpu (i) tot +=per_cpu (bh_accounting, i).nr; buffer_heads_over_limit = (tot > max_buffer_heads); }
fs/proc/proc_misc.c +1 -1
@@ -368,7 +368,7 @@if (wall_to_monotonic.tv_nsec) --jif; -for_each_online_cpu (i) { +for_each_cpu (i) {int j; user +=kstat_cpu (i).cpustat.user;
Signature · 1 line
Anyone who quotes me in their signature is an idiot -- Rusty Russell