remove old ifdef'd code from
Quoted 9 lines · Randy.Dunlap
On Mon, 17 May 2004 14:44:49 +0200 Domen Puncer wrote:
| Hi. | | I'm not attaching this inline, it's 80k and might make someone unhappy. | 4 patches are at: http://coderock.org/kernel/janitor/old_ifdefs_scsi-gdth/ | | Comments?
Quoted 6 lines
They look OK to me. A couple of small items:
If I were doing these (not saying that this is any kind of requirement :), I would add:
a. 'diffstat -p1' output
drivers/scsi/gdth.c | 736 ++++------------------------------------------- drivers/scsi/gdth.h | 34 -- drivers/scsi/gdth_proc.c | 208 ++----------- drivers/scsi/gdth_proc.h | 10 4 files changed, 103 insertions(+), 885 deletions(-)
Quoted 2 lines
b. comments like "I built and loaded it. Don't have hardware
to test it."
I usually just 'make ... .o', is that enough, or should i compile it as module and/or in-kernel?
In this case... compiles as in-kernel and module, and loads as module.
Quoted 4 lines
It might be a good idea to check the init and exit sections for mis-use with something like:
http://developer.osdl.org/rddunlap/scripts/reference_init26.pl
and report that also.
Funny, gdth passes this, but lots of other stuff don't.
Quoted 3 lines
Or in general just report what you have done in order to have some confidence in these (any) patches. (This is meant to be a general comment, not directed at Domen in particular.)
Point taken, will try not to forget this in future.
Quoted 2 lines
--
~Randy
Domen
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 7 lines · Domen Puncer
...
Quoted 2 lines
b. comments like "I built and loaded it. Don't have hardware
to test it."I usually just 'make ... .o', is that enough, or should i compile it as module and/or in-kernel?
...
At least one of these two (in the modular case including a "make modules_install") should suffice.
Quoted 1 line
Domen
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors