IPsec/crypto kernel panic in 2.6.[456]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): Xine.LNX.4.44.0405200409530.15731-100000@thoron.boston.redhat.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 8 lines · David S. Miller
Quoted 5 lines
Quoted 2 lines
erp, unprivileged users can oops the box? Is anyone looking into this?
I hope Christophe can, as he can also verify that the original problem remains fixed.
James is travelling today, and if Christophe doesn't get to it I'll dig into this today.
I've no idea what's going on there. I found two small problems but they don't explain the Oops.
It looks like dst points into nirvana.
The two problems I found:
After calling scatterwalk_copychunks walk_in might point to the next page which will break scatterwalk_samebuf (in this case src_p should point to tmp_src anyway and scatterwalk_samembuf returns 0).
scatterwalk_samebuf should also check for equal offsets inside the page (just bad for performance in some cases).
Both don't explain the Oops and shouldn't corrupt data,
crypto/cipher.c +4 -3
@@ -68,19 +68,20 @@for (;;) {u8 *src_p, *dst_p; +int in_place;scatterwalk_map (&walk_in,0 );scatterwalk_map (&walk_out,1 ); src_p =scatterwalk_whichbuf (&walk_in, bsize, tmp_src); dst_p =scatterwalk_whichbuf (&walk_out, bsize, tmp_dst); + in_place =scatterwalk_samebuf (&walk_in, &walk_out, + src_p, dst_p); nbytes -= bsize;scatterwalk_copychunks (src_p, &walk_in, bsize,0 ); -prfn (tfm, dst_p, src_p, crfn, enc, info, -scatterwalk_samebuf (&walk_in, &walk_out, - src_p, dst_p)); +prfn (tfm, dst_p, src_p, crfn, enc, info, in_place);scatterwalk_done (&walk_in,0 , nbytes);
crypto/scatterwalk.h +1 -0
@@ -38,6 +38,7 @@ void *src_p, void *dst_p) { return walk_in->page == walk_out->page && + walk_in->offset == walk_out->offset && walk_in->data == src_p && walk_out->data == dst_p; }
Hello,
Small update: Tobias Ringström told me that the Oops goes away when he applies the bugfix I sent Andrew. We're still trying to find out what exactly was happening.
Quoted 8 lines
The two problems I found:
After calling
scatterwalk_copychunkswalk_inmight point to the next page which will breakscatterwalk_samebuf(in this casesrc_pshould point totmp_srcanyway andscatterwalk_samembufreturns 0).
scatterwalk_samebufshould also check for equal offsets inside the page (just bad for performance in some cases).