Skip to contentSkip to conversation

emu10k1x patch

DISCUSSION Takashi Iwai 1 participant 1 message May 25, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

At Tue, 25 May 2004 11:52:19 GMT,

Quoted 10 lines · [email protected] wrote:
Quoted 9 lines

188,189c188,189

<       .period_bytes_min =     64,
<       .period_bytes_max =     (32*1024),

---

Quoted 2 lines
      .period_bytes_min =     (16*1024),
      .period_bytes_max =     (16*1024),
Quoted 6 lines
Quoted 4 lines

are you sure this change is correct?
in the current code, the period size is always bound to (buffer_size / 2) (because periods_min = periods_max = 2). so you don't have to limit period_bytes or period_size.

To me, the result was the same,

well, it should be same casually in your setting...

Quoted 2 lines

but I thought it would be cleaner
this way, but I don't care. It seems to work both ways.

ok.

Quoted 12 lines
Quoted 11 lines

732,733c732,733

<       //  snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP<<1);
<       //  snd_emu10k1x_intr_enable(chip, INTE_CH_0_LOOP<<2);

---

Quoted 2 lines
      snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<1);
      snd_emu10k1x_intr_enable(chip, (INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<2);

hmm, it looks redundant.
the second line will override the setting of the first line. i guess you wanted like the following?

Quoted 8 lines
Quoted 3 lines
	snd_emu10k1x_intr_enable(chip,
			(INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<1 |
			(INTE_CH_0_LOOP|INTE_CH_0_HALF_LOOP)<<2);

Both will actually do the samething, because snd_emu10k1x_intr_enable will read the current register value and OR the requested interrupts to it (same thing is done in the emu10k1 code, so I just tried to keep it consistent).

yes, you're right. i've overseen it.
still it would be better to call once with all or'ed bits. i'll change the code on CVS, which will go into 1.0.5-rc2.

BTW, at the next time, please post the patch with unified diff style (diff -u)?

thanks,

Takashi

-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click