replacing driver_data access by
Quoted 7 lines · Yoon Soo
as I can see, this is mostly cosmetic and doesnt change the code too much. So it is just tested to compile and modified kernel is running without probs here. But many changes didnt touched it anyway, because these drivers are unused here.
Hope it is ok. I took care of tabs and spaces..I think. Another
question: Should I split a patch of this size or is it ok?
Patch per file is usualy better, especialy if they get sent to different people.
In this case, maybe patch per directory would be better.
In addition to what Greg, some nit picking from me:
Quoted 2 lines
(quoted diff) +1
-1- eisa_root_dev.dev.driver_data = &eisa_bus_root; + dev_set_drvdata(eisa_root_dev.dev,&eisa_bus_root);
...
Review
Quoted 3 lines
(quoted diff) +1
-1- ud->device.driver_data = node_info; + dev_set_drvdata(ud->device,node_info); new_node->ud = ud;
Space after ',' please.
Review
Quoted 2 lines
(quoted diff) +1
-1- node_info = (struct eth1394_node_info*)ud->device.driver_data; + node_info = (struct eth1394_node_info*)dev_get_drvdata(ud->device);
driver_data is (void *), so you can remove type casts.
Review
Quoted 5 lines
diff -u1 -prN -X dontdiff
linux-2.6.6-orig/drivers/s390/cio/ccwgroup.c(quoted diff) +2
-2- if (cdev->dev.driver_data) { - gdev = (struct ccwgroup_device *)cdev->dev.driver_data; + if (dev_get_drvdata(cdev->dev)) { + gdev = (struct ccwgroup_device *)dev_get_drvdata(cdev->dev);
How about:
gdev = dev_get_drvdata(cdev->dev)
if (gdev) { ...
Domen
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors