Skip to contentSkip to conversation

makefile fix

PATCH carbonated beverage 3 participants 3 messages May 29, 2004 – May 31, 2004 Kbuild

lore
Share & tools
lore
#0 lore raw

Every time I build on the Ultra, I get a file called "64" in the top-level directory. Here's a small patch to make it do the right thing(tm).

Note, I'm using ash as my /bin/sh. Works for me, at least, with bash and ash.

-- DN
Daniel

===== Makefile 1.487 vs edited =====

Makefile +1 -1
@@ -680,7 +680,7 @@
 uts_len := 64
 
 define filechk_version.h
-	if ((`echo -n "$(KERNELRELEASE)" | wc -c ` > $(uts_len))); then \
+	if [ `echo -n "$(KERNELRELEASE)" | wc -c ` -gt $(uts_len) ]; then \
 	  echo '"$(KERNELRELEASE)" exceeds $(uts_len) characters' >&2; \
 	  exit 1; \
 	fi; \
#1 lore raw

The (( x > y )) syntax looks like ksh stuff, equivalent to the more widely supported [ x -gt y ].

Your patch looks reasonable to me.

Signature · 3 lines
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <[email protected]> 1.650.933.1373
#2 lore raw
In reply to carbonated beverage
Quoted 5 lines · carbonated beverage

Every time I build on the Ultra, I get a file called "64" in the top-level directory. Here's a small patch to make it do the right thing(tm).

Note, I'm using ash as my /bin/sh. Works for me, at least, with bash and ash.

Patch is already in Linus' tree. Christoph digged it out of Debian.

Sam