drivers/media/video/tda7432.c: ACK return on

PATCH New Arthur Othieno 1 participant 1 message May 19, 2005 Media (V4L/DVB)

lore

Share & tools

lore

Arthur Othieno

author

2005-05-19 06:25 UTC #0 lore raw

PATCH 1/1 drivers/media/video/tda7432.c: ACK return on

Hi,

i2c_add_driver() may actually fail, but this driver returns 0 regardless. Against 2.6.7. Thanks.

Signed-off-by Arthur Othieno <[email protected]>

 tda7432.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

drivers/media/video/tda7432.c +4 -4

@@ -532,17 +532,17 @@ static struct i2c_client client_template
 	.driver     = &driver, 
 };
 
-static int tda7432_init(void)
+static int __init tda7432_init(void)
 {
 	if ( (loudness < 0) || (loudness > 15) ) {
 		printk(KERN_ERR "tda7432: loudness parameter must be between 0 and 15\n");
 		return -EINVAL;
 	}
-	i2c_add_driver(&driver);
-	return 0;
+
+	return i2c_add_driver(&driver);
 }
 
-static void tda7432_fini(void)
+static void __exit tda7432_fini(void)
 {
 	i2c_del_driver(&driver);
 }