drivers/media/video/tda9840.c: ACK return on

PATCH New Arthur Othieno 1 participant 1 message May 19, 2005 Media (V4L/DVB)

lore

Share & tools

lore

Arthur Othieno

author

2005-05-19 06:25 UTC #0 lore raw

PATCH 1/1 drivers/media/video/tda9840.c: ACK return on

Hi,

i2c_add_driver() may actually fail, but this driver returns 0 regardless. Against 2.6.7. Thanks.

Signed-off-by Arthur Othieno <[email protected]>

 tda9840.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

drivers/media/video/tda9840.c +3 -4

@@ -268,13 +268,12 @@ static struct i2c_driver driver = {
         .command	= tda9840_command,
 };
 
-static int tda9840_init_module(void)
+static int __init tda9840_init_module(void)
 {
-        i2c_add_driver(&driver);
-        return 0;
+        return i2c_add_driver(&driver);
 }
 
-static void tda9840_cleanup_module(void)
+static void __exit tda9840_cleanup_module(void)
 {
         i2c_del_driver(&driver);
 }