Skip to contentSkip to conversation

Allow root to choose vfat policy to UTF8

PATCH Arjan van de Ven 2 participants 2 messages Jun 24, 2004 VFAT/FAT/msdos filesystem

lore
Share & tools
lore
#0 lore raw

Hi,

Right now the kernel detects the sysadmin trying to set the iocharset of vfat to UTF8 and prevents this with an error. While I can see that this is not recommended, enforcing this is policy that probably doesn't belong in the kernel. The patch below makes this situation a warning and a recommendation instead of a strong blockage.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=126641

is an example of a sysadmin disliking this policy enforcement.

Greetings,
Arjan van de Ven

fs/fat/inode.c renamed from fs/fat/inode.c~ +2 -3
@@ -499,9 +499,8 @@
 	}
 	/* UTF8 doesn't provide FAT semantics */
 	if (!strcmp(opts->iocharset, "utf8")) {
-		printk(KERN_ERR "FAT: utf8 is not a valid IO charset"
-		       " for FAT filesystems\n");
-		return -EINVAL;
+		printk(KERN_ERR "FAT: utf8 is not a recommended IO charset"
+		       " for FAT filesystems, filesystem will be case sensitive!\n");
 	}
 
 	if (opts->unicode_xlate)
maintainer
#1 lore raw

fs/fat/inode.c line 504

Quoted 12 lines · Arjan van de Ven
fs/fat/inode.c renamed from fs/fat/inode.c~ +2 -3
@@ -499,9 +499,8 @@
 	}
 	/* UTF8 doesn't provide FAT semantics */
 	if (!strcmp(opts->iocharset, "utf8")) {
-		printk(KERN_ERR "FAT: utf8 is not a valid IO charset"
-		       " for FAT filesystems\n");
-		return -EINVAL;
+		printk(KERN_ERR "FAT: utf8 is not a recommended IO charset"
+		       " for FAT filesystems, filesystem will be case sensitive!\n");
 	}

Umm.. why don't use "iocharset=<xxx>,utf8" instead? This is less unsatisfactory than it option.

Would we still need it? If we still need, I think patch should be applied.

Signature · 1 line
OGAWA Hirofumi <[email protected]>