Skip to contentSkip to conversation

add required dependencies to X86_NUMAQ

PATCH In review Adrian Bunk 2 participants 3 messages Jun 24, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add required dependencies to X86_NUMAQ

If you select another option, you have to ensure that the dependencies of the selected options are met.

The following patch adds to X86_NUMAQ the required dependencies for the selected NUMA:

arch/i386/Kconfig renamed from arch/i386/Kconfig.old +1 -0
@@ -65,6 +65,7 @@
 
 config X86_NUMAQ
 	bool "NUMAQ (IBM/Sequent)"
+	depends on SMP && HIGHMEM64G
 	select DISCONTIGMEM
 	select NUMA
 	help

Please apply
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 9 lines

If you select another option, you have to ensure that the dependencies of the selected options are met.

The following patch adds to X86_NUMAQ the required dependencies for the selected NUMA:

arch/i386/Kconfig line 71

Quoted 7 lines
arch/i386/Kconfig renamed from arch/i386/Kconfig.old +1 -0
@@ -65,6 +65,7 @@
 
 config X86_NUMAQ
 	bool "NUMAQ (IBM/Sequent)"
+	depends on SMP && HIGHMEM64G
 	select DISCONTIGMEM
 	select NUMA
 	help

Mmmm. As we already have this:

config NUMA
bool "Numa Memory Allocation and Scheduler Support"
depends on SMP && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || (X86_SU
MMIT && ACPI))
default n if X86_PC
default y if (X86_NUMAQ || X86_SUMMIT)

do we really need to cascade it back out like that into everything that selects NUMA? Perhaps we should make NUMA select SMP && HIGHMEM64G, rather than depend on it?

M.

#2 lore raw
Quoted 26 lines · Martin J. Bligh
Quoted 9 lines

If you select another option, you have to ensure that the dependencies of the selected options are met.

The following patch adds to X86_NUMAQ the required dependencies for the selected NUMA:

arch/i386/Kconfig line 71

Quoted 7 lines
arch/i386/Kconfig renamed from arch/i386/Kconfig.old +1 -0
@@ -65,6 +65,7 @@
 
 config X86_NUMAQ
 	bool "NUMAQ (IBM/Sequent)"
+	depends on SMP && HIGHMEM64G
 	select DISCONTIGMEM
 	select NUMA
 	help

Mmmm. As we already have this:

config NUMA
bool "Numa Memory Allocation and Scheduler Support"
depends on SMP && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || (X86_SU
MMIT && ACPI))
default n if X86_PC
default y if (X86_NUMAQ || X86_SUMMIT)

Quoted 3 lines

do we really need to cascade it back out like that into everything that selects NUMA? Perhaps we should make NUMA select SMP && HIGHMEM64G, rather than depend on it?

This would work for SMP, but according to my testing, select doesn't seem to work with options in choices like HIGHMEM64G.

Quoted 1 line

M.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed